[executorch] Manual LICM for mutable/const_data_ptr calls in quantize ops #3784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ops Profiling showed that these calls were not getting inlined in ATen mode. Since function calls can have side effects, lack of inlining prevented the compiler from doing this transform itself. Differential Revision: [D57987182](https://our.internmc.facebook.com/intern/diff/D57987182/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D57987182/)! [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3784
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 007482a with merge base 1ad4ae6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57987182 |
…in quantize ops" Profiling showed that these calls were not getting inlined in ATen mode. Since function calls can have side effects, lack of inlining prevented the compiler from doing this transform itself. Differential Revision: [D57987182](https://our.internmc.facebook.com/intern/diff/D57987182/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D57987182/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D57987182 |
larryliu0820
approved these changes
May 30, 2024
…in quantize ops" Profiling showed that these calls were not getting inlined in ATen mode. Since function calls can have side effects, lack of inlining prevented the compiler from doing this transform itself. Differential Revision: [D57987182](https://our.internmc.facebook.com/intern/diff/D57987182/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D57987182/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D57987182 |
|
This pull request has been merged in d1d2e7a. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
… ops Pull Request resolved: pytorch/executorch#3784 Profiling showed that these calls were not getting inlined in ATen mode. Since function calls can have side effects, lack of inlining prevented the compiler from doing this transform itself. ghstack-source-id: 228354914 @exported-using-ghexport Differential Revision: [D57987182](https://our.internmc.facebook.com/intern/diff/D57987182/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D57987182/)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Profiling showed that these calls were not getting inlined in ATen mode. Since function calls can have side effects, lack of inlining prevented the compiler from doing this transform itself.
Differential Revision: D57987182
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!