Skip to content

Enable build on aarch64 linux #3896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Enable build on aarch64 linux #3896

wants to merge 1 commit into from

Conversation

per
Copy link
Collaborator

@per per commented Jun 7, 2024

There's a mismatch in torch and torchvision dependecies for the linux-aarch64 packages and missing support in resolve_buck script.

Signed-off-by: Per Åstrand [email protected]

Change-Id: I491499ca5e524fd2788919b6446a370fe44fdb86

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 7, 2024
Copy link

pytorch-bot bot commented Jun 7, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3896

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 3cad3a6 with merge base 172574a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@per per added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jun 7, 2024
@mergennachin mergennachin requested a review from GregoryComer June 7, 2024 15:53
@per per force-pushed the aarch64_build branch 2 times, most recently from 86ea8c2 to 6359b35 Compare June 13, 2024 19:49
@per per requested a review from mergennachin June 14, 2024 21:26
@per per force-pushed the aarch64_build branch from 6359b35 to 7d9a443 Compare June 18, 2024 08:16
Fix missing support in resolve_buck script.

Signed-off-by: Per Åstrand <[email protected]>

Change-Id: I491499ca5e524fd2788919b6446a370fe44fdb86
@mergennachin
Copy link
Contributor

mergennachin commented Jun 18, 2024

@per

resolve_buck.py changes look good.

However, can you revert the changes in pytorch.txt and install_requirements.sh files? I just moved forward with this PR (#4007). So, no need to change those files.

@per per force-pushed the aarch64_build branch from 7d9a443 to 3cad3a6 Compare June 18, 2024 17:51
@per
Copy link
Collaborator Author

per commented Jun 18, 2024

Rebased ontop of HEAD and reverted pytorch changes.

@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mergennachin merged this pull request in 337174c.

@mergennachin
Copy link
Contributor

@pytorchbot cherry-pick --onto release/0.3 -c critical

pytorchbot pushed a commit that referenced this pull request Jun 20, 2024
Summary:
There's a mismatch in torch and torchvision dependecies for the linux-aarch64 packages and missing support in resolve_buck script.

Signed-off-by: Per Åstrand <[email protected]>

Change-Id: I491499ca5e524fd2788919b6446a370fe44fdb86

Pull Request resolved: #3896

Reviewed By: digantdesai

Differential Revision: D58741803

Pulled By: mergennachin

fbshipit-source-id: 7fe598da58ea6fc29726f38cfb394a9eda832c44
(cherry picked from commit 337174c)
@pytorchbot
Copy link
Collaborator

Cherry picking #3896

The cherry pick PR is at #4017 and it is recommended to link a critical cherry pick PR with an issue

Details for Dev Infra team Raised by workflow job

kirklandsign pushed a commit that referenced this pull request Jun 20, 2024
Summary:
There's a mismatch in torch and torchvision dependecies for the linux-aarch64 packages and missing support in resolve_buck script.

Signed-off-by: Per Åstrand <[email protected]>

Change-Id: I491499ca5e524fd2788919b6446a370fe44fdb86

Pull Request resolved: #3896

Reviewed By: digantdesai

Differential Revision: D58741803

Pulled By: mergennachin

fbshipit-source-id: 7fe598da58ea6fc29726f38cfb394a9eda832c44
(cherry picked from commit 337174c)

Co-authored-by: Per Åstrand <[email protected]>
@per per deleted the aarch64_build branch July 5, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants