[ET-VK][EZ] Migrate convolution workgroup API #3996
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expectation these days is to always use the `ComputeGraph` API; we've just been lazy with migration. Doing convolution now since I'm playing with the workgroup size. Differential Revision: [D58681683](https://our.internmc.facebook.com/intern/diff/D58681683/) [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3996
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 106fb11 with merge base bcabc37 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D58681683 |
jorgep31415
added a commit
that referenced
this pull request
Jun 17, 2024
The expectation these days is to always use the `ComputeGraph` API; we've just been lazy with migration. Doing convolution now since I'm playing with the workgroup size. Differential Revision: [D58681683](https://our.internmc.facebook.com/intern/diff/D58681683/) ghstack-source-id: 230549812 Pull Request resolved: #3996
The expectation these days is to always use the `ComputeGraph` API; we've just been lazy with migration. Doing convolution now since I'm playing with the workgroup size. Differential Revision: [D58681683](https://our.internmc.facebook.com/intern/diff/D58681683/) [ghstack-poisoned]
jorgep31415
added a commit
that referenced
this pull request
Jun 17, 2024
Pull Request resolved: #3996 The expectation these days is to always use the `ComputeGraph` API; we've just been lazy with migration. Doing convolution now since I'm playing with the workgroup size. Differential Revision: [D58681683](https://our.internmc.facebook.com/intern/diff/D58681683/) ghstack-source-id: 230551344
|
This pull request was exported from Phabricator. Differential Revision: D58681683 |
nathanaelsee
approved these changes
Jun 17, 2024
|
This pull request has been merged in 99284c7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The expectation these days is to always use the
ComputeGraphAPI; we've just been lazy with migration. Doing convolution now since I'm playing with the workgroup size.Differential Revision: D58681683