Let custom_ops_aot_lib use portable_lib #4024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4024
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d9652f7 with merge base 5e22836 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
larryliu0820
changed the title
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
dbort
approved these changes
Jun 21, 2024
Summary: Currently on Mac we can't import portable_lib then import sdpa_with_kv_cache. The reason is that they both statically link `executorch_no_prim_ops.a` and when they are both dlopen'd in python they are holding 2 copies of the static variables in `executorch_no_prim_ops.a` such as [initialized](https://github.com/pytorch/executorch/blob/main/runtime/platform/default/posix.cpp#L70). Test Plan: On Mac, make sure the pybind custom ops is able to import. ``` from executorch.extension.pybindings import portable_lib from executorch.examples.models.llama2.custom_ops import sdpa_with_kv_cache portable_lib._get_operator_names() > ... > llama::sdpa_with_kv_cache.out ``` Reviewed By: dbort Differential Revision: D58883985 Pulled By: larryliu0820
facebook-github-bot
force-pushed
the
custom_dep
branch
from
5209d05 to
d9652f7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58883985 |
|
@larryliu0820 merged this pull request in 398ce66. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
Summary: After #4024, sdpa is no longer in portable_lib by default, import separately. Differential Revision: D61163753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently on Mac we can't import portable_lib then import sdpa_with_kv_cache. The reason is that they both statically link
executorch_no_prim_ops.aand when they are both dlopen'd in python they are holding 2 copies of the static variables inexecutorch_no_prim_ops.asuch as initialized.Test Plan:
On Mac, make sure the pybind custom ops is able to import.
Reviewers:
Subscribers:
Tasks:
Tags: