update Vulkan nn.module test to support not decomposition #4054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4054
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 96f6e99 with merge base 1ba8946 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/periodic
module: vulkan
|
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58907317 |
|
This pull request was exported from Phabricator. Differential Revision: D58907317 |
huiyujie
force-pushed
the
export-D58907317
branch
from
ba502a5 to
42a50f6
Compare
huiyujie
pushed a commit
to huiyujie/executorch
that referenced
this pull request
Jun 24, 2024
Summary: Pull Request resolved: pytorch#4054 In order to test the operators that are disabled to decompose, we need different APIs from excutorch to compile the model. We need to use `_to_edge_transform_and_lower()` by passing the Vulkan partitioner. If we use this API, we don't use the combination of `to_edge()` and `to_backend()`. https://www.internalfb.com/code/fbsource/[1176a06a4b48]/xplat/executorch/exir/program/_program.py?lines=862 Add a test option in `lower_module_and_test_output`. By default, it will call normal APIs, with `not_decompose` enabled, it will call `_to_edge_transform_and_lower()` instead. Differential Revision: D58907317
huiyujie
pushed a commit
to huiyujie/executorch
that referenced
this pull request
Jun 24, 2024
Summary: Pull Request resolved: pytorch#4054 In order to test the operators that are disabled to decompose, we need different APIs from excutorch to compile the model. We need to use `_to_edge_transform_and_lower()` by passing the Vulkan partitioner. If we use this API, we don't use the combination of `to_edge()` and `to_backend()`. https://www.internalfb.com/code/fbsource/[1176a06a4b48]/xplat/executorch/exir/program/_program.py?lines=862 Add a test option in `lower_module_and_test_output`. By default, it will call normal APIs, with `not_decompose` enabled, it will call `_to_edge_transform_and_lower()` instead. Differential Revision: D58907317
|
This pull request was exported from Phabricator. Differential Revision: D58907317 |
huiyujie
force-pushed
the
export-D58907317
branch
from
42a50f6 to
f5abda2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58907317 |
huiyujie
pushed a commit
to huiyujie/executorch
that referenced
this pull request
Jun 24, 2024
Summary: Pull Request resolved: pytorch#4054 In order to test the operators that are disabled to decompose, we need different APIs from excutorch to compile the model. We need to use `_to_edge_transform_and_lower()` by passing the Vulkan partitioner. If we use this API, we don't use the combination of `to_edge()` and `to_backend()`. https://www.internalfb.com/code/fbsource/[1176a06a4b48]/xplat/executorch/exir/program/_program.py?lines=862 Add a test option in `lower_module_and_test_output`. By default, it will call normal APIs, with `not_decompose` enabled, it will call `_to_edge_transform_and_lower()` instead. Reviewed By: jorgep31415 Differential Revision: D58907317
huiyujie
force-pushed
the
export-D58907317
branch
from
f5abda2 to
0c3b6bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58907317 |
huiyujie
pushed a commit
to huiyujie/executorch
that referenced
this pull request
Jun 24, 2024
Summary: Pull Request resolved: pytorch#4054 In order to test the operators that are disabled to decompose, we need different APIs from excutorch to compile the model. We need to use `_to_edge_transform_and_lower()` by passing the Vulkan partitioner. If we use this API, we don't use the combination of `to_edge()` and `to_backend()`. https://www.internalfb.com/code/fbsource/[1176a06a4b48]/xplat/executorch/exir/program/_program.py?lines=862 Add a test option in `lower_module_and_test_output`. By default, it will call normal APIs, with `not_decompose` enabled, it will call `_to_edge_transform_and_lower()` instead. Reviewed By: jorgep31415 Differential Revision: D58907317
huiyujie
force-pushed
the
export-D58907317
branch
from
0c3b6bc to
d4f65c9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58907317 |
huiyujie
pushed a commit
to huiyujie/executorch
that referenced
this pull request
Jun 24, 2024
Summary: Pull Request resolved: pytorch#4054 In order to test the operators that are disabled to decompose, we need different APIs from excutorch to compile the model. We need to use `_to_edge_transform_and_lower()` by passing the Vulkan partitioner. If we use this API, we don't use the combination of `to_edge()` and `to_backend()`. https://www.internalfb.com/code/fbsource/[1176a06a4b48]/xplat/executorch/exir/program/_program.py?lines=862 Add a test option in `lower_module_and_test_output`. By default, it will call normal APIs, with `not_decompose` enabled, it will call `_to_edge_transform_and_lower()` instead. Reviewed By: jorgep31415 Differential Revision: D58907317
huiyujie
force-pushed
the
export-D58907317
branch
from
d4f65c9 to
6457f7a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58907317 |
huiyujie
force-pushed
the
export-D58907317
branch
from
6457f7a to
ecb9445
Compare
huiyujie
pushed a commit
to huiyujie/executorch
that referenced
this pull request
Jun 25, 2024
Summary: Pull Request resolved: pytorch#4054 In order to test the operators that are disabled to decompose, we need different APIs from excutorch to compile the model. We need to use `_to_edge_transform_and_lower()` by passing the Vulkan partitioner. If we use this API, we don't use the combination of `to_edge()` and `to_backend()`. https://www.internalfb.com/code/fbsource/[1176a06a4b48]/xplat/executorch/exir/program/_program.py?lines=862 Reviewed By: jorgep31415 Differential Revision: D58907317
jorgep31415
approved these changes
Jun 25, 2024
Summary: Pull Request resolved: pytorch#4054 In order to test the operators that are disabled to decompose, we need different APIs from excutorch to compile the model. We need to use `_to_edge_transform_and_lower()` by passing the Vulkan partitioner. If we use this API, we don't use the combination of `to_edge()` and `to_backend()`. https://www.internalfb.com/code/fbsource/[1176a06a4b48]/xplat/executorch/exir/program/_program.py?lines=862 Reviewed By: jorgep31415 Differential Revision: D58907317
|
This pull request was exported from Phabricator. Differential Revision: D58907317 |
huiyujie
force-pushed
the
export-D58907317
branch
from
ecb9445 to
96f6e99
Compare
|
This pull request has been merged in f538eae. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In order to test the operators that are disabled to decompose, we need different APIs from excutorch to compile the model. We need to use
_to_edge_transform_and_lower()by passing the Vulkan partitioner. If we use this API, we don't use the combination ofto_edge()andto_backend().https://www.internalfb.com/code/fbsource/[1176a06a4b48]/xplat/executorch/exir/program/_program.py?lines=862
Add a test option in
lower_module_and_test_output. By default, it will call normal APIs, withnot_decomposeenabled, it will call_to_edge_transform_and_lower()instead.Differential Revision: D58907317