Skip to content

Add support for delegate profiling in event_tracer #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tarun292
Copy link
Contributor

Summary:
This diff should most probably be the final event_tracer diff that adds the user-facing API's for delegate profiling. event_tracer_hooks_delegate.h can be included by delegate authors in their backend runtime code to get access to these interfaces that will enable them to do profiling logging currently and debugging logging in the future.

  • Made changes to event_tracer.h to add the hooks to the EventTracer class.
  • Added event_tracer_hooks_delegate.h that contains the public interfaces that delegate authors can call into.

Differential Revision: D49360145

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 19, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49360145

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49360145

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49360145

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49360145

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49360145

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49360145

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49360145

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49360145

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for resplendent-gnome-14e531 canceled.

Name Link
🔨 Latest commit e122e0e
🔍 Latest deploy log https://app.netlify.com/sites/resplendent-gnome-14e531/deploys/650f7fcdd612450008e0c752

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49360145

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49360145

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49360145

@tarun292 tarun292 force-pushed the export-D49360145 branch 2 times, most recently from 0cd9bfd to 6739191 Compare September 23, 2023 02:10
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49360145

Summary:

This diff should most probably be the final event_tracer diff that adds the user-facing API's for delegate profiling. `event_tracer_hooks_delegate.h` can be included by delegate authors in their backend runtime code to get access to these interfaces that will enable them to do profiling logging currently and debugging logging in the future.
- Made changes to `event_tracer.h` to add the hooks to the `EventTracer` class.
- Added `event_tracer_hooks_delegate.h` that contains the public interfaces that delegate authors can call into.

Reviewed By: dbort

Differential Revision: D49360145
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49360145

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7a1b7f4.

Gasoonjia pushed a commit that referenced this pull request Jul 30, 2024
* Refactor tokenizer

Summary: Prepare to add tiktoken

Test Plan:
Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix more aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix tokenizer read format

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants