Skip to content

Quantization types #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Quantization types #4094

wants to merge 2 commits into from

Conversation

per
Copy link
Collaborator

@per per commented Jul 1, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4094

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Cancelled Job, 1 Unrelated Failure

As of commit 6beacf3 with merge base 561c035 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2024
@per per added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Jul 1, 2024
@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@per per force-pushed the quantization_types branch from f4e34eb to 9b72314 Compare July 5, 2024 07:37
@digantdesai
Copy link
Contributor

Rebase please?

per added 2 commits July 10, 2024 17:41
@per
Expand QuantizationParams to include dtype and limits
9b67464 
In order to support quantization to different types then int8 keep
track of the limits and type as well.

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: Ia5861adfeff4d57676ff06ccf5a7a8213c34efe6
@per
Remove hard coded argument types
6beacf3 
Move away from implicitly assuming arguments are torch.int8 and
figure out the type from the quantization nodes instead.
This is done to prepare for breaking up the TOSA conversion and
serialization into separate parts.

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: Id88ef8f264e6af8e90a92a00fca13cdbcc857bab
@per per force-pushed the quantization_types branch from 9b72314 to 6beacf3 Compare July 10, 2024 17:21
@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@digantdesai merged this pull request in 074a81e.

@per per deleted the quantization_types branch November 15, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

@kimishpatel kimishpatel Awaiting requested review from kimishpatel

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

Assignees

@digantdesai digantdesai

Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@per @facebook-github-bot @digantdesai