-
Notifications
You must be signed in to change notification settings - Fork 607
conv1d fix #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conv1d fix #411
Conversation
This pull request was exported from Phabricator. Differential Revision: D49428868 |
This pull request was exported from Phabricator. Differential Revision: D49428868 |
3 similar comments
This pull request was exported from Phabricator. Differential Revision: D49428868 |
This pull request was exported from Phabricator. Differential Revision: D49428868 |
This pull request was exported from Phabricator. Differential Revision: D49428868 |
Summary: Fix conv1d to handle both unlifted=True and unlifted=False. When unlifted is False, we need to update the node for the parameter. `setattr` doesn't work there. In a follow-up diff, we add that to torch._export.utils Reviewed By: digantdesai Differential Revision: D49428868
This pull request was exported from Phabricator. Differential Revision: D49428868 |
This pull request has been merged in 96b83ce. |
This reverts commit 052fb1a3792123e291fb5f47084644913c8ecba7 to fix [test-tinystories-executorch](https://github.com/pytorch/torchchat/actions/runs/8802811768/job/24159454773?pr=411#logs)
Summary:
Fix conv1d to handle both unlifted=True and unlifted=False.
When unlifted is False, we need to update the node for the parameter.
setattr
doesn't work there.In a follow-up diff, we add that to torch._export.utils
Differential Revision: D49428868