Move portable/util.py into extension/export_util #4141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`portable/util.py` is used by multiple example models including llm models. Since we are moving llm models' export libraries into `extension/llm/export`, it makes sense to move `portable/util.py` into extension as well. This change does that. It moves the test into `examples/models` which seems to be a better place for these unit tests since they test the export flow for different models and also rely on some code under `examples/models` like `EagerModelFactory`. Differential Revision: [D59306348](https://our.internmc.facebook.com/intern/diff/D59306348/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4141
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 53748ac with merge base 29fdaa1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59306348 |
helunwencser
added a commit
that referenced
this pull request
Jul 3, 2024
`portable/util.py` is used by multiple example models including llm models. Since we are moving llm models' export libraries into `extension/llm/export`, it makes sense to move `portable/util.py` into extension as well. This change does that. It moves the test into `examples/models` which seems to be a better place for these unit tests since they test the export flow for different models and also rely on some code under `examples/models` like `EagerModelFactory`. Differential Revision: [D59306348](https://our.internmc.facebook.com/intern/diff/D59306348/) ghstack-source-id: 232405434 Pull Request resolved: #4141
`portable/util.py` is used by multiple example models including llm models. Since we are moving llm models' export libraries into `extension/llm/export`, it makes sense to move `portable/util.py` into extension as well. This change does that. It moves the test into `examples/models` which seems to be a better place for these unit tests since they test the export flow for different models and also rely on some code under `examples/models` like `EagerModelFactory`. Differential Revision: [D59306348](https://our.internmc.facebook.com/intern/diff/D59306348/) [ghstack-poisoned]
helunwencser
added a commit
that referenced
this pull request
Jul 3, 2024
Pull Request resolved: #4141 `portable/util.py` is used by multiple example models including llm models. Since we are moving llm models' export libraries into `extension/llm/export`, it makes sense to move `portable/util.py` into extension as well. This change does that. It moves the test into `examples/models` which seems to be a better place for these unit tests since they test the export flow for different models and also rely on some code under `examples/models` like `EagerModelFactory`. It also fixes the import hack inside `executorch/examples/models/llama2/builder.py`. Differential Revision: [D59306348](https://our.internmc.facebook.com/intern/diff/D59306348/) ghstack-source-id: 232553687
|
This pull request was exported from Phabricator. Differential Revision: D59306348 |
larryliu0820
approved these changes
Jul 8, 2024
`portable/util.py` is used by multiple example models including llm models. Since we are moving llm models' export libraries into `extension/llm/export`, it makes sense to move `portable/util.py` into extension as well. This change does that. It moves the test into `examples/models` which seems to be a better place for these unit tests since they test the export flow for different models and also rely on some code under `examples/models` like `EagerModelFactory`. Differential Revision: [D59306348](https://our.internmc.facebook.com/intern/diff/D59306348/) [ghstack-poisoned]
helunwencser
added a commit
that referenced
this pull request
Jul 8, 2024
Pull Request resolved: #4141 `portable/util.py` is used by multiple example models including llm models. Since we are moving llm models' export libraries into `extension/llm/export`, it makes sense to move `portable/util.py` into extension as well. This change does that. It moves the test into `examples/models` which seems to be a better place for these unit tests since they test the export flow for different models and also rely on some code under `examples/models` like `EagerModelFactory`. It also fixes the import hack inside `executorch/examples/models/llama2/builder.py`. ghstack-source-id: 232865153 Differential Revision: [D59306348](https://our.internmc.facebook.com/intern/diff/D59306348/)
|
This pull request was exported from Phabricator. Differential Revision: D59306348 |
`portable/util.py` is used by multiple example models including llm models. Since we are moving llm models' export libraries into `extension/llm/export`, it makes sense to move `portable/util.py` into extension as well. This change does that. It moves the test into `examples/models` which seems to be a better place for these unit tests since they test the export flow for different models and also rely on some code under `examples/models` like `EagerModelFactory`. Differential Revision: [D59306348](https://our.internmc.facebook.com/intern/diff/D59306348/) [ghstack-poisoned]
helunwencser
added a commit
that referenced
this pull request
Jul 8, 2024
Pull Request resolved: #4141 `portable/util.py` is used by multiple example models including llm models. Since we are moving llm models' export libraries into `extension/llm/export`, it makes sense to move `portable/util.py` into extension as well. This change does that. It moves the test into `examples/models` which seems to be a better place for these unit tests since they test the export flow for different models and also rely on some code under `examples/models` like `EagerModelFactory`. It also fixes the import hack inside `executorch/examples/models/llama2/builder.py`. ghstack-source-id: 232898293 Differential Revision: [D59306348](https://our.internmc.facebook.com/intern/diff/D59306348/)
|
This pull request was exported from Phabricator. Differential Revision: D59306348 |
`portable/util.py` is used by multiple example models including llm models. Since we are moving llm models' export libraries into `extension/llm/export`, it makes sense to move `portable/util.py` into extension as well. This change does that. It moves the test into `examples/models` which seems to be a better place for these unit tests since they test the export flow for different models and also rely on some code under `examples/models` like `EagerModelFactory`. Differential Revision: [D59306348](https://our.internmc.facebook.com/intern/diff/D59306348/) [ghstack-poisoned]
helunwencser
added a commit
that referenced
this pull request
Jul 9, 2024
Pull Request resolved: #4141 `portable/util.py` is used by multiple example models including llm models. Since we are moving llm models' export libraries into `extension/llm/export`, it makes sense to move `portable/util.py` into extension as well. This change does that. It moves the test into `examples/models` which seems to be a better place for these unit tests since they test the export flow for different models and also rely on some code under `examples/models` like `EagerModelFactory`. It also fixes the import hack inside `executorch/examples/models/llama2/builder.py`. ghstack-source-id: 233035427 Differential Revision: [D59306348](https://our.internmc.facebook.com/intern/diff/D59306348/)
|
This pull request was exported from Phabricator. Differential Revision: D59306348 |
|
This pull request has been merged in 2d9c6b5. |
|
helunwencser
added a commit
that referenced
this pull request
Jul 9, 2024
#4141 missed updating export_and_delegate.py. This PR adds it. Differential Revision: [D59547264](https://our.internmc.facebook.com/intern/diff/D59547264/) [ghstack-poisoned]
helunwencser
added a commit
that referenced
this pull request
Jul 9, 2024
#4141 missed updating export_and_delegate.py. This PR adds it. Differential Revision: [D59547264](https://our.internmc.facebook.com/intern/diff/D59547264/) ghstack-source-id: 233107223 Pull Request resolved: #4193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
portable/util.pyis used by multiple example models including llm models. Since we are moving llm models' export libraries intoextension/llm/export, it makes sense to moveportable/util.pyinto extension as well.
This change does that.
It moves the test into
examples/modelswhich seems to be a better place for these unit tests since they test the export flow for different models and also rely on some code underexamples/modelslikeEagerModelFactory.Differential Revision: D59306348