Skip to content

Introduce new DataLoader::load() with segment info #4158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jackzhxng
Copy link
Contributor

@jackzhxng jackzhxng commented Jul 5, 2024

Summary

Adds a new DataLoader::load() function with an additonal parameter, SegmentInfo.

Diff stack:

  • (x) [1/n][executorch] Introduce new DataLoader::load() with segment info
  • ( ) [2/n][executorch] Switch to DataLoader::load in runtime
  • ( ) [3/n][executorch] Pass in correct backend id into data load from runtime

Differential Revision: D59399538

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 5, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59399538

Copy link

pytorch-bot bot commented Jul 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4158

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9deb8f3 with merge base d159de2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59399538

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jul 10, 2024
Summary:
Pull Request resolved: pytorch#4158

Adds a new `DataLoader::load()` function with an additonal parameter, SegmentInfo. Makes the old `DataLoader::Load()` function deprecated.

Differential Revision: D59399538
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59399538

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jul 10, 2024
Summary:
Pull Request resolved: pytorch#4158

Adds a new `DataLoader::load()` function with an additonal parameter, SegmentInfo. Makes the old `DataLoader::Load()` function deprecated.

Differential Revision: D59399538
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59399538

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jul 10, 2024
Summary:
Pull Request resolved: pytorch#4158

Adds a new `DataLoader::load()` function with an additonal parameter, SegmentInfo. Makes the old `DataLoader::Load()` function deprecated.

Differential Revision: D59399538
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59399538

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59399538

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jul 10, 2024
Summary:
Pull Request resolved: pytorch#4158

Adds a new `DataLoader::load()` function with an additonal parameter, SegmentInfo. Makes the old `DataLoader::Load()` function deprecated.

Differential Revision: D59399538
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59399538

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jul 11, 2024
Summary:
Pull Request resolved: pytorch#4158

Adds a new `DataLoader::load()` function with an additonal parameter, SegmentInfo. Makes the old `DataLoader::Load()` function deprecated.

Reviewed By: dbort

Differential Revision: D59399538
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59399538

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jul 11, 2024
Summary:
Pull Request resolved: pytorch#4158

Adds a new `DataLoader::load()` function with an additonal parameter, SegmentInfo. Makes the old `DataLoader::Load()` function deprecated.

Diff stack:
- (**x**) [[1/n][executorch] Introduce new DataLoader::load() with segment info](https://www.internalfb.com/diff/D59399538?dst_version_fbid=2979141262226992)
- (  ) [[2/n][executorch] Switch to DataLoader::load in runtime](https://www.internalfb.com/diff/D59594142)
- (  ) [[3/n][executorch] Pass in correct backend id into data load from runtime](https://www.internalfb.com/diff/D59606243)

Reviewed By: dbort

Differential Revision: D59399538
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59399538

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jul 11, 2024
Summary:
Pull Request resolved: pytorch#4158

Adds a new `DataLoader::load()` function with an additonal parameter, SegmentInfo. Makes the old `DataLoader::Load()` function deprecated.

Diff stack:
- (**x**) [[1/n][executorch] Introduce new DataLoader::load() with segment info](https://www.internalfb.com/diff/D59399538?dst_version_fbid=2979141262226992)
- (  ) [[2/n][executorch] Switch to DataLoader::load in runtime](https://www.internalfb.com/diff/D59594142)
- (  ) [[3/n][executorch] Pass in correct backend id into data load from runtime](https://www.internalfb.com/diff/D59606243)

Reviewed By: dbort

Differential Revision: D59399538
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59399538

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jul 12, 2024
Summary:
Pull Request resolved: pytorch#4158

Adds a new `DataLoader::load()` function with an additonal parameter, SegmentInfo. Makes the old `DataLoader::Load()` function deprecated.

Diff stack:
- (**x**) [[1/n][executorch] Introduce new DataLoader::load() with segment info](https://www.internalfb.com/diff/D59399538?dst_version_fbid=2979141262226992)
- (  ) [[2/n][executorch] Switch to DataLoader::load in runtime](https://www.internalfb.com/diff/D59594142)
- (  ) [[3/n][executorch] Pass in correct backend id into data load from runtime](https://www.internalfb.com/diff/D59606243)

Reviewed By: dbort

Differential Revision: D59399538
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59399538

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jul 12, 2024
Summary:
Pull Request resolved: pytorch#4158

Adds a new `DataLoader::load()` function with an additonal parameter, SegmentInfo. Makes the old `DataLoader::Load()` function deprecated.

Diff stack:
- (**x**) [[1/n][executorch] Introduce new DataLoader::load() with segment info](https://www.internalfb.com/diff/D59399538?dst_version_fbid=2979141262226992)
- (  ) [[2/n][executorch] Switch to DataLoader::load in runtime](https://www.internalfb.com/diff/D59594142)
- (  ) [[3/n][executorch] Pass in correct backend id into data load from runtime](https://www.internalfb.com/diff/D59606243)

Reviewed By: dbort

Differential Revision: D59399538
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59399538

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Jul 13, 2024
Summary:
Pull Request resolved: pytorch#4158

Adds a new `DataLoader::load()` function with an additonal parameter, SegmentInfo. Makes the old `DataLoader::Load()` function deprecated.

Diff stack:
- (**x**) [[1/n][executorch] Introduce new DataLoader::load() with segment info](https://www.internalfb.com/diff/D59399538?dst_version_fbid=2979141262226992)
- (  ) [[2/n][executorch] Switch to DataLoader::load in runtime](https://www.internalfb.com/diff/D59594142)
- (  ) [[3/n][executorch] Pass in correct backend id into data load from runtime](https://www.internalfb.com/diff/D59606243)

Reviewed By: dbort

Differential Revision: D59399538
Summary:
Pull Request resolved: pytorch#4158

Adds a new `DataLoader::load()` function with an additonal parameter, SegmentInfo. Makes the old `DataLoader::Load()` function deprecated.

Diff stack:
- (**x**) [[1/n][executorch] Introduce new DataLoader::load() with segment info](https://www.internalfb.com/diff/D59399538?dst_version_fbid=2979141262226992)
- (  ) [[2/n][executorch] Switch to DataLoader::load in runtime](https://www.internalfb.com/diff/D59594142)
- (  ) [[3/n][executorch] Pass in correct backend id into data load from runtime](https://www.internalfb.com/diff/D59606243)

Reviewed By: dbort

Differential Revision: D59399538
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59399538

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in bda0f7c.

@jackzhxng jackzhxng deleted the export-D59399538 branch July 18, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants