RegCount max registers calculation #4171
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4171
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59494644 |
SS-JIA
approved these changes
Jul 9, 2024
Esteb37
pushed a commit
to Esteb37/executorch
that referenced
this pull request
Jul 10, 2024
Summary: Pull Request resolved: pytorch#4171 This project adds an internal implementation of https://github.com/microsoft/ArchProbe. This stack introduces a kernel that can be used to get the number of available registers on a mobile GPU by gradually increasing the number of accessed elements and detecting dramatic drops in performance. See [this paper](https://www.microsoft.com/en-us/research/uploads/prod/2022/02/mobigpu_mobicom22_camera.pdf), page 4, for more information. This diffs finds the number of registers in a single thread by increasing the number of registers and finding changes in latency. For a Galaxy S22, the latency graph looks like this. {F1750619092} We can easily spot the moment where there is a spill into memory. Differential Revision: D59494644 Reviewed By: SS-JIA
Esteb37
pushed a commit
to Esteb37/executorch
that referenced
this pull request
Jul 11, 2024
Summary: Pull Request resolved: pytorch#4171 This project adds an internal implementation of https://github.com/microsoft/ArchProbe. This stack introduces a kernel that can be used to get the number of available registers on a mobile GPU by gradually increasing the number of accessed elements and detecting dramatic drops in performance. See [this paper](https://www.microsoft.com/en-us/research/uploads/prod/2022/02/mobigpu_mobicom22_camera.pdf), page 4, for more information. This diffs finds the number of registers in a single thread by increasing the number of registers and finding changes in latency. For a Galaxy S22, the latency graph looks like this. {F1750619092} We can easily spot the moment where there is a spill into memory. Differential Revision: D59494644 Reviewed By: SS-JIA
Esteb37
pushed a commit
to Esteb37/executorch
that referenced
this pull request
Jul 11, 2024
Summary: Pull Request resolved: pytorch#4171 This project adds an internal implementation of https://github.com/microsoft/ArchProbe. This stack introduces a kernel that can be used to get the number of available registers on a mobile GPU by gradually increasing the number of accessed elements and detecting dramatic drops in performance. See [this paper](https://www.microsoft.com/en-us/research/uploads/prod/2022/02/mobigpu_mobicom22_camera.pdf), page 4, for more information. This diffs finds the number of registers in a single thread by increasing the number of registers and finding changes in latency. For a Galaxy S22, the latency graph looks like this. {F1750619092} We can easily spot the moment where there is a spill into memory. Differential Revision: D59494644 Reviewed By: SS-JIA
|
This pull request was exported from Phabricator. Differential Revision: D59494644 |
Esteb37
pushed a commit
to Esteb37/executorch
that referenced
this pull request
Jul 11, 2024
Summary: Pull Request resolved: pytorch#4171 This project adds an internal implementation of https://github.com/microsoft/ArchProbe. This stack introduces a kernel that can be used to get the number of available registers on a mobile GPU by gradually increasing the number of accessed elements and detecting dramatic drops in performance. See [this paper](https://www.microsoft.com/en-us/research/uploads/prod/2022/02/mobigpu_mobicom22_camera.pdf), page 4, for more information. This diffs finds the number of registers in a single thread by increasing the number of registers and finding changes in latency. For a Galaxy S22, the latency graph looks like this. {F1751910439} We can easily spot the moment where there is a spill into memory. Reviewed By: SS-JIA Differential Revision: D59494644
Esteb37
force-pushed
the
export-D59494644
branch
from
1c3d9d2 to
037b5de
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59494644 |
Esteb37
pushed a commit
to Esteb37/executorch
that referenced
this pull request
Jul 11, 2024
Summary: Pull Request resolved: pytorch#4171 This project adds an internal implementation of https://github.com/microsoft/ArchProbe. This stack introduces a kernel that can be used to get the number of available registers on a mobile GPU by gradually increasing the number of accessed elements and detecting dramatic drops in performance. See [this paper](https://www.microsoft.com/en-us/research/uploads/prod/2022/02/mobigpu_mobicom22_camera.pdf), page 4, for more information. This diffs finds the number of registers in a single thread by increasing the number of registers and finding changes in latency. For a Galaxy S22, the latency graph looks like this. {F1751910439} We can easily spot the moment where there is a spill into memory. Reviewed By: SS-JIA Differential Revision: D59494644
Esteb37
force-pushed
the
export-D59494644
branch
from
037b5de to
1813297
Compare
Esteb37
pushed a commit
to Esteb37/executorch
that referenced
this pull request
Jul 11, 2024
Summary: Pull Request resolved: pytorch#4171 This project adds an internal implementation of https://github.com/microsoft/ArchProbe. This stack introduces a kernel that can be used to get the number of available registers on a mobile GPU by gradually increasing the number of accessed elements and detecting dramatic drops in performance. See [this paper](https://www.microsoft.com/en-us/research/uploads/prod/2022/02/mobigpu_mobicom22_camera.pdf), page 4, for more information. This diffs finds the number of registers in a single thread by increasing the number of registers and finding changes in latency. For a Galaxy S22, the latency graph looks like this. {F1750619092} We can easily spot the moment where there is a spill into memory. Differential Revision: D59494644 Reviewed By: SS-JIA
Summary: Pull Request resolved: pytorch#4159 This adds an internal implementation of https://github.com/microsoft/ArchProbe. This stack introduces a kernel that can be used to get the number of available registers on a mobile GPU by gradually increasing the number of accessed elements and detecting dramatic drops in performance. See [this paper ](https://www.microsoft.com/en-us/research/uploads/prod/2022/02/mobigpu_mobicom22_camera.pdf), page 4, for more information. This first diff gets the number of iterations (NITER) that can run in 1000us, to be used in the following tests. The kernel looks like the following for any K number of registers: float reg_data0 = float(niter) + 0; float reg_data1 = float(niter) + 1; ... float reg_dataK = float(niter) + K; int i = 0; for (; i < niter; ++i) { reg_data0 *= reg_dataK; reg_data1 *= reg_data0; reg_data2 *= reg_data1; ... reg_dataK *= reg_data(K-1); } i = i >> 31; buffer_out.data[0 * i] = reg_data0; buffer_out.data[1 * i] = reg_data1; ... buffer_out.data[K * i] = reg_dataK; Differential Revision: D59405012 Reviewed By: SS-JIA
Esteb37
pushed a commit
to Esteb37/executorch
that referenced
this pull request
Jul 11, 2024
Summary: Pull Request resolved: pytorch#4171 This project adds an internal implementation of https://github.com/microsoft/ArchProbe. This stack introduces a kernel that can be used to get the number of available registers on a mobile GPU by gradually increasing the number of accessed elements and detecting dramatic drops in performance. See [this paper](https://www.microsoft.com/en-us/research/uploads/prod/2022/02/mobigpu_mobicom22_camera.pdf), page 4, for more information. This diffs finds the number of registers in a single thread by increasing the number of registers and finding changes in latency. For a Galaxy S22, the latency graph looks like this. {F1750619092} We can easily spot the moment where there is a spill into memory. Differential Revision: D59494644 Reviewed By: SS-JIA
Summary: Pull Request resolved: pytorch#4171 This project adds an internal implementation of https://github.com/microsoft/ArchProbe. This stack introduces a kernel that can be used to get the number of available registers on a mobile GPU by gradually increasing the number of accessed elements and detecting dramatic drops in performance. See [this paper](https://www.microsoft.com/en-us/research/uploads/prod/2022/02/mobigpu_mobicom22_camera.pdf), page 4, for more information. This diffs finds the number of registers in a single thread by increasing the number of registers and finding changes in latency. For a Galaxy S22, the latency graph looks like this. {F1751910439} We can easily spot the moment where there is a spill into memory. Reviewed By: SS-JIA Differential Revision: D59494644
Esteb37
pushed a commit
to Esteb37/executorch
that referenced
this pull request
Jul 11, 2024
Summary: Pull Request resolved: pytorch#4171 This project adds an internal implementation of https://github.com/microsoft/ArchProbe. This stack introduces a kernel that can be used to get the number of available registers on a mobile GPU by gradually increasing the number of accessed elements and detecting dramatic drops in performance. See [this paper](https://www.microsoft.com/en-us/research/uploads/prod/2022/02/mobigpu_mobicom22_camera.pdf), page 4, for more information. This diffs finds the number of registers in a single thread by increasing the number of registers and finding changes in latency. For a Galaxy S22, the latency graph looks like this. {F1750619092} We can easily spot the moment where there is a spill into memory. Differential Revision: D59494644 Reviewed By: SS-JIA
|
This pull request was exported from Phabricator. Differential Revision: D59494644 |
Esteb37
force-pushed
the
export-D59494644
branch
from
1813297 to
ef51787
Compare
|
This pull request has been merged in 09336a6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project adds an internal implementation of https://github.com/microsoft/ArchProbe.
This stack introduces a kernel that can be used to get the number of available registers on a mobile GPU by gradually increasing the number of accessed elements and detecting dramatic drops in performance. See this paper, page 4, for more information.
This diffs finds the number of registers in a single thread by increasing the number of registers and finding changes in latency. For a Galaxy S22, the latency graph looks like this.
We can easily spot the moment where there is a spill into memory.
Differential Revision: D59494644