Move builder.py into extension #4188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does the following things: - rename `LlamaEdgeManager` to `LLMEdgeManager` - clean up some unused parameters: `weight_type`, `use_sdpa_with_kv_cache` - move `model.params.max_seq_len` out of `builder.py` - move `builder.py` into `extension/llm/export` Differential Revision: [D59493975](https://our.internmc.facebook.com/intern/diff/D59493975/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4188
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit 9dc2fd7 with merge base b10b763 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59493975 |
This was referenced Jul 9, 2024
larryliu0820
approved these changes
Jul 10, 2024
This PR does the following things: - rename `LlamaEdgeManager` to `LLMEdgeManager` - clean up some unused parameters: `weight_type`, `use_sdpa_with_kv_cache` - move `model.params.max_seq_len` out of `builder.py` - move `builder.py` into `extension/llm/export` Differential Revision: [D59493975](https://our.internmc.facebook.com/intern/diff/D59493975/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D59493975 |
|
This pull request has been merged in 4fa7cfc. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#4188 This PR does the following things: - rename `LlamaEdgeManager` to `LLMEdgeManager` - clean up some unused parameters: `weight_type`, `use_sdpa_with_kv_cache` - move `model.params.max_seq_len` out of `builder.py` - move `builder.py` into `extension/llm/export` ghstack-source-id: 233306023 @exported-using-ghexport Differential Revision: [D59493975](https://our.internmc.facebook.com/intern/diff/D59493975/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR does the following things:
LlamaEdgeManagertoLLMEdgeManagerweight_type,use_sdpa_with_kv_cachemodel.params.max_seq_lenout ofbuilder.pybuilder.pyintoextension/llm/exportDifferential Revision: D59493975