Switch to DataLoader::load in runtime #4217
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4217
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 0ba5f7d with merge base d159de2 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59594142 |
|
This pull request was exported from Phabricator. Differential Revision: D59594142 |
jackzhxng
force-pushed
the
export-D59594142
branch
from
ef3ff4a to
1091fc4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59594142 |
jackzhxng
added a commit
to jackzhxng/executorch
that referenced
this pull request
Jul 11, 2024
Summary: Pull Request resolved: pytorch#4217 Description - Makes the appropriate changes in runtime code to deprecate DataLoader::Load in favor of DataLoader::load with SegmentInfo. - Adds tests for the load function Follow-ups planned in diff stack - (D59606243) Currently `program.cpp` is passing in a hardcoded`"backend_segment"` as the descriptor, but in a follow-up will pass in the actual backend id. - Test `Constant` segment case Diff stack: - ( ) [[1/n][executorch] Introduce new DataLoader::load() with segment info](https://www.internalfb.com/diff/D59399538?dst_version_fbid=2979141262226992) - (**x**) [[2/n][executorch] Switch to DataLoader::load in runtime](https://www.internalfb.com/diff/D59594142) - ( ) [[3/n][executorch] Pass in correct backend id into data load from runtime](https://www.internalfb.com/diff/D59606243) Differential Revision: D59594142
jackzhxng
force-pushed
the
export-D59594142
branch
from
1091fc4 to
67e5290
Compare
dbort
approved these changes
Jul 12, 2024
|
This pull request was exported from Phabricator. Differential Revision: D59594142 |
jackzhxng
force-pushed
the
export-D59594142
branch
from
67e5290 to
4a1ef22
Compare
jackzhxng
added a commit
to jackzhxng/executorch
that referenced
this pull request
Jul 12, 2024
Summary: Pull Request resolved: pytorch#4217 Description - Makes the appropriate changes in runtime code to deprecate DataLoader::Load in favor of DataLoader::load with SegmentInfo. - Adds tests for the load function Follow-ups planned in diff stack - (D59606243) Currently `program.cpp` is passing in a hardcoded`"backend_segment"` as the descriptor, but in a follow-up will pass in the actual backend id. - Test `Constant` segment case Diff stack: - ( ) [[1/n][executorch] Introduce new DataLoader::load() with segment info](https://www.internalfb.com/diff/D59399538?dst_version_fbid=2979141262226992) - (**x**) [[2/n][executorch] Switch to DataLoader::load in runtime](https://www.internalfb.com/diff/D59594142) - ( ) [[3/n][executorch] Pass in correct backend id into data load from runtime](https://www.internalfb.com/diff/D59606243) Reviewed By: dbort Differential Revision: D59594142
Summary: Adds a new DataLoader::load() function with an additonal parameter, SegmentInfo. Differential Revision: D59399538
jackzhxng
added a commit
to jackzhxng/executorch
that referenced
this pull request
Jul 13, 2024
Summary: Pull Request resolved: pytorch#4217 Description - Makes the appropriate changes in runtime code to deprecate DataLoader::Load in favor of DataLoader::load with SegmentInfo. - Adds tests for the load function Follow-ups planned in diff stack - (D59606243) Currently `program.cpp` is passing in a hardcoded`"backend_segment"` as the descriptor, but in a follow-up will pass in the actual backend id. - Test `Constant` segment case Diff stack: - ( ) [[1/n][executorch] Introduce new DataLoader::load() with segment info](https://www.internalfb.com/diff/D59399538?dst_version_fbid=2979141262226992) - (**x**) [[2/n][executorch] Switch to DataLoader::load in runtime](https://www.internalfb.com/diff/D59594142) - ( ) [[3/n][executorch] Pass in correct backend id into data load from runtime](https://www.internalfb.com/diff/D59606243) Reviewed By: dbort Differential Revision: D59594142
|
This pull request was exported from Phabricator. Differential Revision: D59594142 |
jackzhxng
force-pushed
the
export-D59594142
branch
from
4a1ef22 to
ecc004d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59594142 |
jackzhxng
added a commit
to jackzhxng/executorch
that referenced
this pull request
Jul 13, 2024
Summary: Pull Request resolved: pytorch#4217 Description - Makes the appropriate changes in runtime code to deprecate DataLoader::Load in favor of DataLoader::load with SegmentInfo. - Adds tests for the load function Follow-ups planned in diff stack - (D59606243) Currently `program.cpp` is passing in a hardcoded`"backend_segment"` as the descriptor, but in a follow-up will pass in the actual backend id. - Test `Constant` segment case Diff stack: - ( ) [[1/n][executorch] Introduce new DataLoader::load() with segment info](https://www.internalfb.com/diff/D59399538?dst_version_fbid=2979141262226992) - (**x**) [[2/n][executorch] Switch to DataLoader::load in runtime](https://www.internalfb.com/diff/D59594142) - ( ) [[3/n][executorch] Pass in correct backend id into data load from runtime](https://www.internalfb.com/diff/D59606243) Reviewed By: dbort Differential Revision: D59594142
jackzhxng
force-pushed
the
export-D59594142
branch
from
ecc004d to
291f820
Compare
Summary: Pull Request resolved: pytorch#4217 Description - Makes the appropriate changes in runtime code to deprecate DataLoader::Load in favor of DataLoader::load with SegmentInfo. - Adds tests for the load function Follow-ups planned in diff stack - (D59606243) Currently `program.cpp` is passing in a hardcoded`"backend_segment"` as the descriptor, but in a follow-up will pass in the actual backend id. - Test `Constant` segment case Diff stack: - ( ) [[1/n][executorch] Introduce new DataLoader::load() with segment info](https://www.internalfb.com/diff/D59399538?dst_version_fbid=2979141262226992) - (**x**) [[2/n][executorch] Switch to DataLoader::load in runtime](https://www.internalfb.com/diff/D59594142) - ( ) [[3/n][executorch] Pass in correct backend id into data load from runtime](https://www.internalfb.com/diff/D59606243) Reviewed By: dbort Differential Revision: D59594142
|
This pull request was exported from Phabricator. Differential Revision: D59594142 |
jackzhxng
force-pushed
the
export-D59594142
branch
from
291f820 to
0ba5f7d
Compare
|
This pull request has been merged in c7e407e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups planned in diff stack
program.cppis passing in a hardcoded"backend_segment"as the descriptor, but in a follow-up will pass in the actual backend id.Constantsegment caseDiff stack:
Differential Revision: D59594142