Pass in correct backend id into data load from runtime #4218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4218
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 5edbae8 with merge base d159de2 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59606243 |
|
This pull request was exported from Phabricator. Differential Revision: D59606243 |
jackzhxng
force-pushed
the
export-D59606243
branch
from
f7b8034 to
d061c94
Compare
dbort
approved these changes
Jul 13, 2024
added 2 commits
July 12, 2024 17:20
Summary: Adds a new DataLoader::load() function with an additonal parameter, SegmentInfo. Differential Revision: D59399538
Summary: Makes the appropriate changes in runtime code to deprecate DataLoader::Load in favor of DataLoader::load with the next SegmentInfo. Differential Revision: D59594142
|
This pull request was exported from Phabricator. Differential Revision: D59606243 |
jackzhxng
added a commit
to jackzhxng/executorch
that referenced
this pull request
Jul 13, 2024
Summary: Pull Request resolved: pytorch#4218 The runtime now passes in the backend id into the SegmentInfo for its load() call. Diff stack: - ( ) [[1/n][executorch] Introduce new DataLoader::load() with segment info](https://www.internalfb.com/diff/D59399538?dst_version_fbid=2979141262226992) - ( ) [[2/n][executorch] Switch to DataLoader::load in runtime](https://www.internalfb.com/diff/D59594142) - (**x**) [[3/n][executorch] Pass in correct backend id into data load from runtime](https://www.internalfb.com/diff/D59606243) Reviewed By: dbort Differential Revision: D59606243
jackzhxng
force-pushed
the
export-D59606243
branch
from
d061c94 to
a6baea7
Compare
jackzhxng
added a commit
to jackzhxng/executorch
that referenced
this pull request
Jul 13, 2024
Summary: Pull Request resolved: pytorch#4218 The runtime now passes in the backend id into the SegmentInfo for its load() call. Diff stack: - ( ) [[1/n][executorch] Introduce new DataLoader::load() with segment info](https://www.internalfb.com/diff/D59399538?dst_version_fbid=2979141262226992) - ( ) [[2/n][executorch] Switch to DataLoader::load in runtime](https://www.internalfb.com/diff/D59594142) - (**x**) [[3/n][executorch] Pass in correct backend id into data load from runtime](https://www.internalfb.com/diff/D59606243) Reviewed By: dbort Differential Revision: D59606243
jackzhxng
force-pushed
the
export-D59606243
branch
from
a6baea7 to
ac7d0b6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59606243 |
Summary: Pull Request resolved: pytorch#4218 The runtime now passes in the backend id into the SegmentInfo for its load() call. Diff stack: - ( ) [[1/n][executorch] Introduce new DataLoader::load() with segment info](https://www.internalfb.com/diff/D59399538?dst_version_fbid=2979141262226992) - ( ) [[2/n][executorch] Switch to DataLoader::load in runtime](https://www.internalfb.com/diff/D59594142) - (**x**) [[3/n][executorch] Pass in correct backend id into data load from runtime](https://www.internalfb.com/diff/D59606243) Reviewed By: dbort Differential Revision: D59606243
|
This pull request was exported from Phabricator. Differential Revision: D59606243 |
jackzhxng
force-pushed
the
export-D59606243
branch
from
ac7d0b6 to
5edbae8
Compare
|
This pull request has been merged in 93a7725. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The runtime now passes in the backend id into the SegmentInfo for its load() call.
Diff stack:
Differential Revision: D59606243