Use cmake to build runner dependencies. #4238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4238
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 0e1199c with merge base d863214 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59672358 |
Summary: Pull Request resolved: #4238 Building some of the llama runner dependencies like RE2 and Abseil is non-trivial via Xcode, so let's make Xcode leverage cmake to build those. The downside is the customers will need to install cmake on their Macs, but that's a tolerable con. Differential Revision: D59672358
|
This pull request was exported from Phabricator. Differential Revision: D59672358 |
kirklandsign
approved these changes
Jul 12, 2024
|
This pull request has been merged in 728c1f6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Building some of the llama runner dependencies like RE2 and Abseil is non-trivial via Xcode, so let's make Xcode leverage cmake to build those.
The downside is the customers will need to install cmake on their Macs, but that's a tolerable con.
Differential Revision: D59672358