Skip to content

Support llama3.1 #4376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Support llama3.1 #4376

wants to merge 8 commits into from

Conversation

larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Jul 23, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D60129927

@larryliu0820
Support llama3.1
a90505d 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4376

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e3d82aa with merge base dbc73a6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

larryliu0820 added a commit that referenced this pull request Jul 23, 2024
@larryliu0820
Support llama3.1
cb2e586 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 6357c8b
Pull Request resolved: #4376
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2024
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "Support llama3.1"
6a50152 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D60129927](https://our.internmc.facebook.com/intern/diff/D60129927)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 23, 2024
@larryliu0820
Support llama3.1
5a2c5d1 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 1e29544
Pull Request resolved: #4376
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "Support llama3.1"
17c1c66 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D60129927](https://our.internmc.facebook.com/intern/diff/D60129927)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 23, 2024
@larryliu0820
Support llama3.1
13cc88d 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 5ace7e9
Pull Request resolved: #4376
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@lucylq lucylq mentioned this pull request Jul 23, 2024
Closed
Gasoonjia
Gasoonjia approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@Gasoonjia Gasoonjia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please solve the pyre issue before landing

@larryliu0820
Update on "Support llama3.1"
7782a96 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D60129927](https://our.internmc.facebook.com/intern/diff/D60129927)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 24, 2024
@larryliu0820
Support llama3.1
40f862e 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 584457a
Pull Request resolved: #4376
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "Support llama3.1"
3d88322 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D60129927](https://our.internmc.facebook.com/intern/diff/D60129927)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 24, 2024
@larryliu0820
Support llama3.1
0f03456 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ef14440
Pull Request resolved: #4376
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "Support llama3.1"
53d9d55 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D60129927](https://our.internmc.facebook.com/intern/diff/D60129927)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 24, 2024
@larryliu0820
Support llama3.1
dae1b17 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: bcb2c8c
Pull Request resolved: #4376
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "Support llama3.1"
468433a 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D60129927](https://our.internmc.facebook.com/intern/diff/D60129927)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 24, 2024
@larryliu0820
Support llama3.1
0107b17 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: bd07edc
Pull Request resolved: #4376
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "Support llama3.1"
e3d82aa 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D60129927](https://our.internmc.facebook.com/intern/diff/D60129927)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 24, 2024
@larryliu0820
Support llama3.1
ce574d6 
Summary: Add scaled RoPE

Test Plan: Test official checkpoint and gives meaningful result.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 992395f
Pull Request resolved: #4376
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6c69ebd.

facebook-github-bot pushed a commit that referenced this pull request Jul 24, 2024
@lucylq @facebook-github-bot
Add llama3.1 to readme (#4378)
e87b4f4 
Summary:
#4376


Reviewed By: kirklandsign

Differential Revision: D60177343

Pulled By: lucylq
facebook-github-bot pushed a commit that referenced this pull request Jul 24, 2024
@lucylq @facebook-github-bot
Add llama3.1 to readme (#4378)
d6d691e 
Summary:
#4376

Pull Request resolved: #4378

Reviewed By: kirklandsign

Differential Revision: D60177343

Pulled By: lucylq

fbshipit-source-id: f8197e7af18785bfcca3c5c2980ec1bd7acdaf9d
pytorchbot pushed a commit that referenced this pull request Jul 24, 2024
@lucylq @pytorchbot
Add llama3.1 to readme (#4378)
f2f6c96 
Summary:
#4376

Pull Request resolved: #4378

Reviewed By: kirklandsign

Differential Revision: D60177343

Pulled By: lucylq

fbshipit-source-id: f8197e7af18785bfcca3c5c2980ec1bd7acdaf9d
(cherry picked from commit d6d691e)
@pytorchbot pytorchbot mentioned this pull request Jul 24, 2024
Merged
lucylq added a commit that referenced this pull request Jul 24, 2024
@pytorchbot @lucylq
Add llama3.1 to readme (#4378) (#4403)
0d0f580 
Summary:
#4376

Pull Request resolved: #4378

Reviewed By: kirklandsign

Differential Revision: D60177343

Pulled By: lucylq

fbshipit-source-id: f8197e7af18785bfcca3c5c2980ec1bd7acdaf9d
(cherry picked from commit d6d691e)

Co-authored-by: lucylq <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gasoonjia Gasoonjia Gasoonjia approved these changes

@cccclai cccclai Awaiting requested review from cccclai

@iseeyuan iseeyuan Awaiting requested review from iseeyuan

@mergennachin mergennachin Awaiting requested review from mergennachin

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larryliu0820 @facebook-github-bot @Gasoonjia