use flatc from conda instead of build from source #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The generated header file using flatc from conda (https://anaconda.org/conda-forge/flatbuffers) ``` conda install -c conda-forge flatbuffers ``` only works with flatbuffers 2020, including both on host and android. We can instruct users to install flatc like ``` conda install -c "conda-forge/label/cf202003" flatbuffers ``` to upgrade flatc to latest version, but I've tried to do ``` conda install -c "conda-forge/label/cf202307" flatbuffers ``` and the generated header file still doesn't compile with flatbuffers library Differential Revision: D49487908
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49487908 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The generated header file using flatc from conda (https://anaconda.org/conda-forge/flatbuffers)
only works with flatbuffers 2020, including both on host and android. We can instruct users to install flatc like
to upgrade flatc to latest version, but I've tried to do
and the generated header file still doesn't compile with flatbuffers library
Differential Revision: D49487908