-
Notifications
You must be signed in to change notification settings - Fork 606
add proper calibration to pt2e flow #4452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Differential Revision: [D60419364](https://our.internmc.facebook.com/intern/diff/D60419364/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4452
Note: Links to docs will display an error until the docs builds have been completed. ❌ 8 New FailuresAs of commit 290ca5d with merge base a743a3b ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Differential Revision: [D60419364](https://our.internmc.facebook.com/intern/diff/D60419364/) ghstack-source-id: 235717228 Pull Request resolved: #4452
This pull request was exported from Phabricator. Differential Revision: D60419364 |
Differential Revision: [D60419364](https://our.internmc.facebook.com/intern/diff/D60419364/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D60419364 |
Pull Request resolved: #4452 Differential Revision: [D60419364](https://our.internmc.facebook.com/intern/diff/D60419364/) ghstack-source-id: 235862897
Differential Revision: [D60419364](https://our.internmc.facebook.com/intern/diff/D60419364/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D60419364 |
Pull Request resolved: #4452 ghstack-source-id: 235865853 Differential Revision: [D60419364](https://our.internmc.facebook.com/intern/diff/D60419364/)
Differential Revision: [D60419364](https://our.internmc.facebook.com/intern/diff/D60419364/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D60419364 |
Pull Request resolved: #4452 ghstack-source-id: 236234222 Differential Revision: [D60419364](https://our.internmc.facebook.com/intern/diff/D60419364/)
) | ||
|
||
tokenizer = get_tokenizer(tokenizer_path) | ||
eval_wrapper = EagerEvalWrapper( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cccclai,
Thanks for this change.
It seems to have a problem when I capture seq_len = 1 in kv_cache mode but calibrate with whole sequence in batch process.
From my understanding, after we capture, some variable will be fixed such as "batch, seqlen, _ = x.shape".
If I am mistaken, please correct me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi thank you for checking out the pr! I pulled some changes from another local patch and haven't tested this pr properly. What you mentioned is true...I vaguelly remember I modified the code there to use kv cache instead, however it was too slow to calibrate (as you observed too)
Create a new pr #5095 instead as this pr wasn't tested properly |
Stack from ghstack (oldest at bottom):
Differential Revision: D60419364