Skip to content

[executorch] Migrate runtime/platform tests to new namespace #4606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 15, 2024

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Aug 9, 2024

dbort added 2 commits August 8, 2024 17:34
Migrate these headers to the new `::executorch::runtime` namespace. Add temporary aliases from the old `::torch::executor` namespace so we can migrate users incrementally.

The tests for these headers are updated in the next diff to help demonstrate that the backwards-compatibility aliases work.

Differential Revision: [D60418073](https://our.internmc.facebook.com/intern/diff/D60418073/)

[ghstack-poisoned]
The previous commit moved headers to the `::executorch::runtime` namespace. This diff updates the tests for those changes. After this, these tests should not use `::torch::executor` for the updated names.

Differential Revision: [D60428953](https://our.internmc.facebook.com/intern/diff/D60428953/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Aug 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4606

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fbbcb8c with merge base 5d151d0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60428953

dbort added 2 commits August 8, 2024 18:20
…s to new namespace"

The previous commit moved headers to the `::executorch::runtime` namespace. This diff updates the tests for those changes. After this, these tests should not use `::torch::executor` for the updated names.

Differential Revision: [D60428953](https://our.internmc.facebook.com/intern/diff/D60428953/)

[ghstack-poisoned]
The previous commit moved headers to the `::executorch::runtime` namespace. This diff updates the tests for those changes. After this, these tests should not use `::torch::executor` for the updated names.

Differential Revision: [D60428953](https://our.internmc.facebook.com/intern/diff/D60428953/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60428953

dbort added 2 commits August 9, 2024 12:31
…s to new namespace"

The previous commit moved headers to the `::executorch::runtime` namespace. This diff updates the tests for those changes. After this, these tests should not use `::torch::executor` for the updated names.

Differential Revision: [D60428953](https://our.internmc.facebook.com/intern/diff/D60428953/)

[ghstack-poisoned]
The previous commit moved headers to the `::executorch::runtime` namespace. This diff updates the tests for those changes. After this, these tests should not use `::torch::executor` for the updated names.

Differential Revision: [D60428953](https://our.internmc.facebook.com/intern/diff/D60428953/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60428953

…s to new namespace"

The previous commit moved headers to the `::executorch::runtime` namespace. This diff updates the tests for those changes. After this, these tests should not use `::torch::executor` for the updated names.

Differential Revision: [D60428953](https://our.internmc.facebook.com/intern/diff/D60428953/)

[ghstack-poisoned]
The previous commit moved headers to the `::executorch::runtime` namespace. This diff updates the tests for those changes. After this, these tests should not use `::torch::executor` for the updated names.

Differential Revision: [D60428953](https://our.internmc.facebook.com/intern/diff/D60428953/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60428953

@dbort dbort changed the base branch from gh/dbort/41/base to gh/dbort/40/head August 15, 2024 16:54
Base automatically changed from gh/dbort/40/head to main August 15, 2024 19:15
@facebook-github-bot facebook-github-bot merged commit bf29bd6 into main Aug 15, 2024
34 of 36 checks passed
@dbort dbort deleted the gh/dbort/41/head branch August 15, 2024 20:07
kirklandsign pushed a commit to kirklandsign/executorch that referenced this pull request Aug 15, 2024
Differential Revision: D60428953

Pull Request resolved: pytorch#4606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants