Fix build breaks from llvm-17 #461
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D49556599 |
Summary: Clang-17 is stricter around format strings and ambiguous headers. * Cast the enums to the right format type * Namespace `format_to` methods with `fmt` since libc++ 17 introduces its own std::format Reviewed By: lanza Differential Revision: D49556599
thevinster
force-pushed
the
export-D49556599
branch
from
8e8e018 to
8b78305
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49556599 |
|
This pull request has been merged in a3e6480. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Clang-17 is stricter around format strings and ambiguous headers.
format_tomethods withfmtsince libc++ 17 introduces its own std::formatDifferential Revision: D49556599