[llava][20/N] Add llava runner using building blocks in e/llm/runner #4666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As titled. This PR moves the token generation loop in llama2 runner into a new class so it can be reused. [ghstack-poisoned]
…o a class" As titled. This PR moves the token generation loop in llama2 runner into a new class so it can be reused. Differential Revision: [D61047601](https://our.internmc.facebook.com/intern/diff/D61047601) [ghstack-poisoned]
As titled. This PR moves the token generation loop in llama2 runner into a new class so it can be reused. Differential Revision: [D61047601](https://our.internmc.facebook.com/intern/diff/D61047601) [ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4666
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ef8c92c with merge base 6efc222 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 12, 2024
facebook-github-bot
added
the
CLA Signed
|
Very clean way to build the runner from components, thanks for all the work! Import to internal? |
…ing blocks in e/llm/runner" Add llava runner that uses runner lib in `extension/llm/runner`. [ghstack-poisoned]
…llm/runner" Add llava runner that uses runner lib in `extension/llm/runner`. [ghstack-poisoned]
…ing blocks in e/llm/runner" Add llava runner that uses runner lib in `extension/llm/runner`. [ghstack-poisoned]
…llm/runner" Add llava runner that uses runner lib in `extension/llm/runner`. [ghstack-poisoned]
…ing blocks in e/llm/runner" Add llava runner that uses runner lib in `extension/llm/runner`. [ghstack-poisoned]
…llm/runner" Add llava runner that uses runner lib in `extension/llm/runner`. [ghstack-poisoned]
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…ing blocks in e/llm/runner" Add llava runner that uses runner lib in `extension/llm/runner`. Differential Revision: [D61292846](https://our.internmc.facebook.com/intern/diff/D61292846) [ghstack-poisoned]
…llm/runner" Add llava runner that uses runner lib in `extension/llm/runner`. Differential Revision: [D61292846](https://our.internmc.facebook.com/intern/diff/D61292846) [ghstack-poisoned]
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
Aug 15, 2024
…ytorch#4666) * [llava][18/N] Move token generation loop to a class As titled. This PR moves the token generation loop in llama2 runner into a new class so it can be reused. [ghstack-poisoned] * [llava][19/N] Add multimodal runner base class and build file [ghstack-poisoned] * [llava][20/N] Add llava runner using building blocks in e/llm/runner [ghstack-poisoned] * Update base for Update on "[llava][20/N] Add llava runner using building blocks in e/llm/runner" Add llava runner that uses runner lib in `extension/llm/runner`. [ghstack-poisoned] * Update base for Update on "[llava][20/N] Add llava runner using building blocks in e/llm/runner" Add llava runner that uses runner lib in `extension/llm/runner`. Differential Revision: [D61292846](https://our.internmc.facebook.com/intern/diff/D61292846) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add llava runner that uses runner lib in
extension/llm/runner.Differential Revision: D61292846