[llava][18/N] Move token generation loop to a class #4705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As titled. This PR moves the token generation loop in llama2 runner into a new class so it can be reused. [ghstack-poisoned]
…o a class" As titled. This PR moves the token generation loop in llama2 runner into a new class so it can be reused. Differential Revision: [D61047601](https://our.internmc.facebook.com/intern/diff/D61047601) [ghstack-poisoned]
As titled. This PR moves the token generation loop in llama2 runner into a new class so it can be reused. Differential Revision: [D61047601](https://our.internmc.facebook.com/intern/diff/D61047601) [ghstack-poisoned]
…o a class" As titled. This PR moves the token generation loop in llama2 runner into a new class so it can be reused. Differential Revision: [D61047601](https://our.internmc.facebook.com/intern/diff/D61047601) [ghstack-poisoned]
As titled. This PR moves the token generation loop in llama2 runner into a new class so it can be reused. Differential Revision: [D61047601](https://our.internmc.facebook.com/intern/diff/D61047601) [ghstack-poisoned]
…o a class" As titled. This PR moves the token generation loop in llama2 runner into a new class so it can be reused. Differential Revision: [D61047601](https://our.internmc.facebook.com/intern/diff/D61047601) [ghstack-poisoned]
As titled. This PR moves the token generation loop in llama2 runner into a new class so it can be reused. Differential Revision: [D61047601](https://our.internmc.facebook.com/intern/diff/D61047601) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4705
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 3 Unrelated FailuresAs of commit 0bda164 with merge base e71fa03 ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
larryliu0820
approved these changes
Aug 13, 2024
kirklandsign
added a commit
to kirklandsign/executorch
that referenced
this pull request
Aug 15, 2024
* [llava][18/N] Move token generation loop to a class As titled. This PR moves the token generation loop in llama2 runner into a new class so it can be reused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[llava][18/N] Move token generation loop to a class
As titled. This PR moves the token generation loop in llama2 runner into
a new class so it can be reused.
Differential Revision: D61047601
Pull Request resolved: #4652