Skip to content

Define @deprecated and @experimental decorators #4744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Aug 16, 2024

Summary:
Define decorators that EXIR can use to annotate non-stable APIs.

I used the name warnings to parallel the new warnings.deprecated decorator from PEP-702.

Also added typing-extensions as an explicit requirement for the pip package. We already use it in other places, but were getting it transitively from the torch package.

Differential Revision: D61367967

Summary:
Define decorators that EXIR can use to annotate non-stable APIs.

I used the name `warnings` to parallel the new `warnings.deprecated` decorator from [PEP-702](https://peps.python.org/pep-0702/).

Also added `typing-extensions` as an explicit requirement for the pip package. We already use it in other places, but were getting it transitively from the `torch` package.

Differential Revision: D61367967
Copy link

pytorch-bot bot commented Aug 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4744

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 97e4b40 with merge base 9a98abb (image):

NEW FAILURE - The following job has failed:

  • Android / test-llama-app (bpe) / mobile-job (android) (gh)
    Could not assume role with user credentials: User: arn:aws:sts::308535385114:assumed-role/gh-ci-github-action-runners-runner-role/i-083a91c1206ddd32e is not authorized to perform: sts:TagSession on resource: arn:aws:iam::308535385114:role/gha_workflow_mobile_job

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 16, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61367967

@facebook-github-bot facebook-github-bot merged commit 96e7f0a into pytorch:main Aug 16, 2024
41 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants