patch annoying clang17 enum print format issue #476
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for resplendent-gnome-14e531 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49549284 |
JacobSzwejbka
force-pushed
the
export-D49549284
branch
from
f9d8b85 to
07ed85d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49549284 |
JacobSzwejbka
force-pushed
the
export-D49549284
branch
from
07ed85d to
e974874
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49549284 |
JacobSzwejbka
force-pushed
the
export-D49549284
branch
from
e974874 to
a6fa5e3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49549284 |
Summary: Catherine beat me to fixing up the clang errors. Fixed up some places the errors werent getting printed in hex while I was here Reviewed By: cccclai Differential Revision: D49549284
JacobSzwejbka
force-pushed
the
export-D49549284
branch
from
a6fa5e3 to
04a8592
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49549284 |
|
This pull request has been merged in 4df1592. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
#476) * set buffer size to 8192 as default, decode precision as a string, lint * typo * typo * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Its no longer kocher to have enums implicitly transformed to their underlying type. We now have to explicitly cast. Also fixed up some places the errors werent getting printed in hex while I was here
Differential Revision: D49549284