Skip to content

[ET] promote to_edge_transform_and_lower to public API #4766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Aug 16, 2024

Stack from ghstack (oldest at bottom):

We wish to make to_edge_transform_and_lower a public API that is accessible through exir and no longer is preceeded with an "_"

Differential Revision: D61050669

We wish to make to_edge_transform_and_lower a public API that is accessible through exir and no longer is preceeded with an "_"

Differential Revision: [D61050669](https://our.internmc.facebook.com/intern/diff/D61050669/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Aug 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4766

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 89d803e with merge base 622de2d (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 16, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61050669

mcr229 added a commit that referenced this pull request Aug 16, 2024
We wish to make to_edge_transform_and_lower a public API that is accessible through exir and no longer is preceeded with an "_"

Differential Revision: [D61050669](https://our.internmc.facebook.com/intern/diff/D61050669/)

ghstack-source-id: 238560379
Pull Request resolved: #4766
@facebook-github-bot facebook-github-bot merged commit fb1faa0 into gh/mcr229/5/base Aug 19, 2024
35 of 37 checks passed
kirklandsign added a commit that referenced this pull request Aug 20, 2024
We wish to make to_edge_transform_and_lower a public API that is accessible through exir and no longer is preceeded with an "_"

Co-authored-by: Max Ren <[email protected]>

Pull Request resolved: #4766
@mcr229 mcr229 deleted the gh/mcr229/5/head branch March 24, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants