[executorch] Make operator<<() wrap long EValue lists #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap long lists at ten items per line. I considered adding another stream manipulator to let users modify this, but it seemed less immediately useful than the "edge_items" manipulator. Also considered wrapping at a particular column number, but it's way easier to count items then to count characters. The indenting on some of the nested elements like Tensors and Tensor lists aren't the best, but we can fix that in a future diff. Differential Revision: [D49607605](https://our.internmc.facebook.com/intern/diff/D49607605/) [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
This was referenced Sep 25, 2023
Wrap long lists at ten items per line. I considered adding another stream manipulator to let users modify this, but it seemed less immediately useful than the "edge_items" manipulator. Also considered wrapping at a particular column number, but it's way easier to count items then to count characters. The indenting on some of the nested elements like Tensors and Tensor lists aren't the best, but we can fix that in a future diff. Differential Revision: [D49607605](https://our.internmc.facebook.com/intern/diff/D49607605/) [ghstack-poisoned]
Wrap long lists at ten items per line. I considered adding another stream manipulator to let users modify this, but it seemed less immediately useful than the "edge_items" manipulator. Also considered wrapping at a particular column number, but it's way easier to count items then to count characters. The indenting on some of the nested elements like Tensors and Tensor lists aren't the best, but we can fix that in a future diff. Differential Revision: [D49607605](https://our.internmc.facebook.com/intern/diff/D49607605/) [ghstack-poisoned]
|
This pull request has been merged in 6914003. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Wrap long lists at ten items per line. I considered adding another stream manipulator to let users modify this, but it seemed less immediately useful than the "edge_items" manipulator.
Also considered wrapping at a particular column number, but it's way easier to count items then to count characters.
The indenting on some of the nested elements like Tensors and Tensor lists aren't the best, but we can fix that in a future diff.
Differential Revision: D49607605