[executorch][preprocess] Remove pad custom op #4801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4801
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e493763 with merge base 78b0867 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
lucylq
force-pushed
the
lfq.update-export-preprocess
branch
4 times, most recently
from
b38bc7b to
d40c8a9
Compare
lucylq
force-pushed
the
lfq.update-export-preprocess
branch
from
d40c8a9 to
e493763
Compare
larryliu0820
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that pytorch/pytorch#132679 is merged we do not need the pad custom op to export preprocess. Also do not need the exir pass to swap out custom op and aten op.