Decouple model e2e tests #487
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49622665 |
guangy10
force-pushed
the
export-D49622665
branch
from
2df919e to
8d69ccb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49622665 |
huydhn
reviewed
Sep 26, 2023
huydhn
reviewed
Sep 26, 2023
huydhn
approved these changes
Sep 26, 2023
guangy10
force-pushed
the
export-D49622665
branch
2 times, most recently
from
c1f3713 to
3997069
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49622665 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49622665 |
Summary: We should not couple e2e tests with different recipes *(e.g. run with portable kernels, run with xnnpack options)* in a single job. Addressing timeout issue and improving CI stability is one of the reasons, however, even w/o timeout we still want to do it for: 1. Maximal parallelism to reduce waiting time 2. Flexibility to enable/disable an e2e test for a given recipe, e.g. disable slow running e2e test with portable kernels but keep the xnnpack e2e tests enabled, or if there are issue with a flavor 3. Cleaner CI job names to describe what it does Of course this is not real fix of the timeout issue we're facing, the complete fix will include 1) introducing release build for both cmake and buck2 and 2) fixing the slow portable kernels from the root. And both are far away and not possible before MVP. For MVP as we have more and more models enabled with XNNPACK as a part of the out-of-box experience, our CI is facing extra stress. See the [ci dashboard](https://hud.pytorch.org/hud/pytorch/executorch/main). The major motivation in this diff is to ensure the healthiness of enabled models as well as our CI. Reviewed By: huydhn, kirklandsign Differential Revision: D49622665
guangy10
force-pushed
the
export-D49622665
branch
from
3997069 to
e71c31f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49622665 |
|
This pull request has been merged in e3104ff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D49622665