Skip to content

preprocess e2e test #4887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2024
Merged

preprocess e2e test #4887

merged 2 commits into from
Aug 27, 2024

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Aug 24, 2024

Run preprocess e2e via pybindings

  • add tile_crop to custom ops Cmake build
  • create unbacked symint to allow dynamic upper-bounded tensor as tile_crop output. Otherwise tensor is static and tile_crop cannot resize.

Test Plan:
python -m unittest examples/models/flamingo/test_preprocess.py

Copy link

pytorch-bot bot commented Aug 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4887

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 933bc69 with merge base d9ae7c3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 24, 2024
@lucylq lucylq force-pushed the lfq.e2e-test branch 5 times, most recently from ac75602 to 0c0899c Compare August 26, 2024 06:04
@lucylq lucylq marked this pull request as ready for review August 26, 2024 06:05
@facebook-github-bot
Copy link
Contributor

@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@lucylq lucylq requested a review from tarun292 August 26, 2024 23:21
(image_tensor, inscribed_size, best_resolution)
)
self.assertTrue(torch.allclose(reference_image, et_image))
self.assertTrue(reference_ar, et_ar)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be assertEqual?

eager_image, eager_ar = eager_model(
image_tensor, inscribed_size, best_resolution
)
eager_ar = eager_ar.tolist()
self.assertTrue(torch.allclose(reference_image, eager_image))
self.assertTrue(reference_ar, eager_ar)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@facebook-github-bot
Copy link
Contributor

@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 1cea0ee into main Aug 27, 2024
37 checks passed
@facebook-github-bot facebook-github-bot deleted the lfq.e2e-test branch August 27, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants