Forbid having TensorImpl with zero number of elements and null data. #4909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4909
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 60a1908 with merge base 7efdfc0 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61810277 |
|
This pull request was exported from Phabricator. Differential Revision: D61810277 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D61810277 |
dbort
approved these changes
Aug 26, 2024
#4909) Summary: Pull Request resolved: #4909 `numel_ == 0 && data_ == nullptr` This represents an empty tensor. Common after initialization or after resizing to zero elements. `numel_ == 0 && data_ != nullptr` Unusual, but this can occur if a tensor is resized to zero elements and retains its allocated memory. Useful for quick resizing back to non-zero elements without reallocation. `numel_ > 0 && data_ == nullptr` Tensor with shape but no allocated memory. Common after initialization or when memory allocation is deferred. `numel_ > 0 && data_ != nullptr` Normal state for a non-empty tensor with allocated memory. Reviewed By: dbort Differential Revision: D61810277
|
This pull request was exported from Phabricator. Differential Revision: D61810277 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: .
Differential Revision: D61810277