Remove logic for appending or prepending tokens #4920
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4920
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 17d39e4 with merge base 0a11e99 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@helunwencser has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Merged
Summary: Pull Request resolved: #4920 The runner should not prepend or append any tokens to the prompt. Users should make sure that the prompt is properly formatted as the model's chat template. This PR removes the logic for appending or prepending tokens. Test Plan: CI imported-using-ghimport Differential Revision: D61824091 Pulled By: helunwencser
|
This pull request was exported from Phabricator. Differential Revision: D61824091 |
helunwencser
force-pushed
the
gh/helunwencser/33/head
branch
from
c1d4884 to
17d39e4
Compare
iseeyuan
approved these changes
Oct 9, 2024
|
@helunwencser merged this pull request in a922b3d. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
ghstack-source-id: faf0542 ghstack-comment-id: 2311228673 Pull Request resolved: pytorch/executorch#4920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runner should not prepend or append any tokens to the prompt. Users should make sure that the prompt is properly formatted as the model's chat template.
This PR removes the logic for appending or prepending tokens.
Test Plan:
CI
Differential Revision: D61824091