Skip to content

serialize fqns. #4931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2024
Merged

serialize fqns. #4931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions exir/emit/_emit_program.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,20 +84,26 @@ def _remove_non_user_outputs(exported_program: ExportedProgram) -> torch.fx.Grap
def _get_training_metadata(methods: Dict[str, ExportedProgram]) -> Dict[str, int]:
gradients_method_prefix = "__et_training_gradients_index_"
parameters_method_prefix = "__et_training_parameters_index_"
fqn_method_prefix = "__et_training_fqn_"
training_metadata = {}
for name, method in methods.items():
found_grad = False
found_param = False
fqns = []
i = 0
for output_spec in method.graph_signature.output_specs:
if output_spec.kind == OutputKind.GRADIENT_TO_PARAMETER and not found_grad:
training_metadata[gradients_method_prefix + name] = i
found_grad = True
if output_spec.kind == OutputKind.GRADIENT_TO_PARAMETER:
if not found_grad:
training_metadata[gradients_method_prefix + name] = i
found_grad = True
fqns.append(output_spec.target)
elif output_spec.kind == OutputKind.TOKEN and not found_param:
assert found_grad # Params must come after gradients
training_metadata[parameters_method_prefix + name] = i
found_param = True
i += 1
if len(fqns) > 0:
training_metadata[fqn_method_prefix + name] = fqns
return training_metadata


Expand Down
11 changes: 9 additions & 2 deletions exir/tests/test_joint_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def forward(self, x, y):
self.assertTrue(torch.allclose(m.linear.bias, et_outputs[4]))

self.assertEqual(
len(et.executorch_program.execution_plan), 3
len(et.executorch_program.execution_plan), 4
) # forward + 2 training metadata functions

# gradient outputs start at index 1
Expand All @@ -121,10 +121,17 @@ def forward(self, x, y):
1,
)

# parameter outputs start at index 3
self.assertEqual(
et.executorch_program.execution_plan[2] # pyre-ignore
.values[0]
.val.string_val,
"linear.weight",
)

# parameter outputs start at index 3
self.assertEqual(
et.executorch_program.execution_plan[3] # pyre-ignore
.values[0]
.val.int_val,
3,
)
Loading