Skip to content

Implement dumping operator distribution for TOSA graph #4970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Aug 29, 2024

When dumping the operator distribution after ArmTeste.partition, operators are counted both in the Edge IR and the TOSA graph. The complete output looks something like:
"operators: {op1: 3, op2: 5....}
TOSA operators: {op1: 2, op2: 3}"

Change-Id: I946e8487ad185d9994049ddcdcf7b08153c2597b

Change-Id: I946e8487ad185d9994049ddcdcf7b08153c2597b
Signed-off-by: Erik Lundell <[email protected]>
Copy link

pytorch-bot bot commented Aug 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4970

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dafdfaa with merge base 7b3549b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2024
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Aug 29, 2024
@jackzhxng jackzhxng requested a review from digantdesai August 29, 2024 23:08
@digantdesai
Copy link
Contributor

Nit: perhaps put example output in the commit message or PR summary?

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Erik-Lundell
Copy link
Collaborator Author

Nit: perhaps put example output in the commit message or PR summary?

Updated the PR summary for both comments :)

@digantdesai
Copy link
Contributor

Seems like ci job test_debug_feats.py::test_dump_tosa_ops is still failing?

Change-Id: I603e6b3245c95d5b7d720325c9467bf8896c630b
@Erik-Lundell
Copy link
Collaborator Author

Seems like ci job test_debug_feats.py::test_dump_tosa_ops is still failing?

Seems like I updated the output message without updating the test, sorry about that. Should be corrected now.

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 91089db into pytorch:main Sep 5, 2024
93 checks passed
@dbort
Copy link
Contributor

dbort commented Sep 5, 2024

@Erik-Lundell @digantdesai The pull / unittest-arm (buck2) / linux-job and trunk / test-arm-reference-delegation / linux-job jobs started failing in trunk (dashboard) after this PR merged.

Example failure (job):

FAILED ../../dev/misc/test_debug_feats.py::test_fail_dump_tosa_ops - SystemExit: 2
= 1 failed, 434 passed, 73 skipped, 134 xfailed, 169 warnings in 467.22s (0:07:47) =

dbort added a commit that referenced this pull request Sep 6, 2024
Reverts #4970

The pull / unittest-arm (buck2) / linux-job and trunk / test-arm-reference-delegation / linux-job jobs started failing in trunk (dashboard) after this PR merged. See #4970 (comment) for more details.
@dbort
Copy link
Contributor

dbort commented Sep 6, 2024

@Erik-Lundell I've reverted this PR in #5131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants