Skip to content

Include stories with qnn in benchinfra #4995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

guangy10
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented Aug 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4995

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 0fd2529 with merge base ff4a736 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 30, 2024
@guangy10
Copy link
Contributor Author

guangy10 commented Aug 30, 2024

Adding the tinyllama+QNN to the android-perf, the benchmark-on-device step fails with the following error:

[PyTorch] Marking the test suite as failed because it failed to load the model

@kirklandsign So I think the LlamaDemoApp we are currently using in the workflow doesn't build with QNN enabled? If yes, the failure is expected. Once we have the generic app, it should build with QNN enabled as well.

@guangy10 guangy10 marked this pull request as ready for review August 30, 2024 17:10
@guangy10 guangy10 requested a review from kirklandsign August 30, 2024 17:11
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 2520d50 into main Aug 30, 2024
42 of 43 checks passed
@facebook-github-bot facebook-github-bot deleted the benchmark_stories_w_qnn branch August 30, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants