-
Notifications
You must be signed in to change notification settings - Fork 607
Android library update for benchmarking support #5000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5000
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled JobsAs of commit fd88afa with merge base e7e8647 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
So far it supports generic model (not LLM). Later we can combine two Build: ``` cd examples/demo-apps/android/MiniBench mkdir app/libs cp <executorch.aar> app/libs/executorch.aar ./gradlew :app:installDebug When we have library changes ready, we can start trying it adb shell am start -n org.pytorch.minibench/org.pytorch.minibench.BenchmarkActivity --es model_path /data/local/tmp/model.pte adb shell run-as org.pytorch.minibench cat files/benchmark_results.txt ```
Test: ``` cd examples/demo-apps/android/MiniBench mkdir app/libs cp <executorch.aar> app/libs/executorch.aar ./gradlew :app:installDebug When we have library changes ready, we can start trying it adb shell am start -n org.pytorch.minibench/org.pytorch.minibench.BenchmarkActivity --es model_path /data/local/tmp/model.pte adb shell run-as org.pytorch.minibench cat files/benchmark_results.txt ```
df37949
to
e0dc99c
Compare
guangy10
approved these changes
Aug 30, 2024
linter errors are legitimate |
kirklandsign
added a commit
that referenced
this pull request
Aug 31, 2024
So far it supports generic model (not LLM). Later we can combine two Build: ``` cd extension/android/benchmark mkdir app/libs cp <executorch.aar> app/libs/executorch.aar ./gradlew :app:installDebug When we have library changes ready (#5000), we can start trying it adb shell am start -n org.pytorch.minibench/org.pytorch.minibench.BenchmarkActivity --es model_path /data/local/tmp/model.pte adb shell run-as org.pytorch.minibench cat files/benchmark_results.txt ``` Pull Request resolved: #5015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: