Skip to content

Android library update for benchmarking support #5000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 31, 2024
Merged

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Aug 30, 2024

Test:

cd examples/demo-apps/android/MiniBench
mkdir app/libs
cp <executorch.aar> app/libs/executorch.aar
./gradlew :app:installDebug

When we have library changes ready, we can start trying it
adb shell am start -n org.pytorch.minibench/org.pytorch.minibench.BenchmarkActivity --es model_path /data/local/tmp/model.pte
adb shell run-as org.pytorch.minibench cat files/benchmark_results.txt

Copy link

pytorch-bot bot commented Aug 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5000

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Cancelled Jobs

As of commit fd88afa with merge base e7e8647 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 30, 2024
So far it supports generic model (not LLM). Later we can combine two

Build:
```
cd examples/demo-apps/android/MiniBench
mkdir app/libs
cp <executorch.aar> app/libs/executorch.aar
./gradlew :app:installDebug

When we have library changes ready, we can start trying it
adb shell am start -n org.pytorch.minibench/org.pytorch.minibench.BenchmarkActivity --es model_path /data/local/tmp/model.pte
adb shell run-as org.pytorch.minibench cat files/benchmark_results.txt
```
@kirklandsign kirklandsign changed the base branch from main to minibench August 30, 2024 22:18
Test:
```
cd examples/demo-apps/android/MiniBench
mkdir app/libs
cp <executorch.aar> app/libs/executorch.aar
./gradlew :app:installDebug

When we have library changes ready, we can start trying it
adb shell am start -n org.pytorch.minibench/org.pytorch.minibench.BenchmarkActivity --es model_path /data/local/tmp/model.pte
adb shell run-as org.pytorch.minibench cat files/benchmark_results.txt
```
@kirklandsign kirklandsign changed the title [test only] try with a temp aar Android library update for benchmarking support Aug 30, 2024
@guangy10
Copy link
Contributor

linter errors are legitimate

kirklandsign added a commit that referenced this pull request Aug 31, 2024
So far it supports generic model (not LLM). Later we can combine two

Build:
```
cd extension/android/benchmark
mkdir app/libs
cp <executorch.aar> app/libs/executorch.aar
./gradlew :app:installDebug

When we have library changes ready (#5000), we can start trying it
adb shell am start -n org.pytorch.minibench/org.pytorch.minibench.BenchmarkActivity --es model_path /data/local/tmp/model.pte
adb shell run-as org.pytorch.minibench cat files/benchmark_results.txt
```

Pull Request resolved: #5015
Base automatically changed from minibench to main August 31, 2024 00:05
@kirklandsign kirklandsign merged commit 61ddee5 into main Aug 31, 2024
43 of 45 checks passed
@kirklandsign kirklandsign deleted the aar-for-bench-2 branch August 31, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants