-
Notifications
You must be signed in to change notification settings - Fork 607
Add event tracing and ETDumps to executor_runner #5027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dbort
merged 22 commits into
pytorch:main
from
benkli01:add-profiling-to-xnn-executor-runner-2
Jan 29, 2025
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b09d09e
Add event tracing and ETDumps to executor_runner
benkli01 cbcbbe7
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 4db02c9
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 bf27add
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 a2c254c
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 3f23fae
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 e692a76
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 1d9d0c0
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 f3493e4
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 1a9721f
Fix comments during code review
benkli01 da448ce
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 b36d5b4
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 fde5862
Small fix for use of flag `FLAGS_etdump`
benkli01 931ddf4
Another fix for case ET_EVENT_TRACER_ENABLED=OFF
benkli01 b080c76
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 88f0e91
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 42a8b9c
Revert use of FLATCCRT_LIB to flatccrt
benkli01 34b6b3e
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 07d1c26
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 c886ad2
Fix linker issue when building executor_runner
benkli01 d9f3269
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 662cb81
Merge branch 'pytorch:main' into add-profiling-to-xnn-executor-runner-2
benkli01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shewu-quic you added this line in https://github.com/pytorch/executorch/pull/2227/files#diff-0f6d37c62838592cf30db121c46cf34a9b9316df4b5a0d98f0ad7c7a98f7ff7eR261
It's currently causing problems because
ET_EVENT_TRACER_ENABLED
only works whenEXECUTORCH_BUILD_DEVTOOLS
is also enabled. Is it ok to remove this, or will other scripts/docs need to change?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be automatically set by the main
CMakeLists.txt
as long as the CMake flagEXECUTORCH_ENABLE_EVENT_TRACER
is enabled.