Skip to content

[eval_llama] Add option to save checkpoint after eager transforms. #5045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

iseeyuan
Copy link
Contributor

@iseeyuan iseeyuan commented Sep 3, 2024

As titled, Save the checkpoint after the eager model preparation is done. The reason for this option is that the checkpoint can be used to do evaluations in other evaluation platforms, or with data that is not available in this eval_llama. We save the checkpoint here for consistency with eval_llama. The accuracy results we get from eval_llama can be used as a reference to other evaluations.

Copy link

pytorch-bot bot commented Sep 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5045

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 441b996 with merge base 32d83b0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2024
@facebook-github-bot
Copy link
Contributor

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Sep 3, 2024
Summary:
As titled, Save the checkpoint after the eager model preparation is done. The reason for this option is that the checkpoint can be used to do evaluations in other evaluation platforms, or with data that is not available in this eval_llama. We save the checkpoint here for consistency with eval_llama. The accuracy results we get from eval_llama can be used as a reference to other evaluations.


Differential Revision: D62150021

Pulled By: iseeyuan
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62150021

facebook-github-bot pushed a commit that referenced this pull request Sep 3, 2024
Summary:
As titled, Save the checkpoint after the eager model preparation is done. The reason for this option is that the checkpoint can be used to do evaluations in other evaluation platforms, or with data that is not available in this eval_llama. We save the checkpoint here for consistency with eval_llama. The accuracy results we get from eval_llama can be used as a reference to other evaluations.


Reviewed By: mergennachin

Differential Revision: D62150021

Pulled By: iseeyuan
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62150021

facebook-github-bot pushed a commit that referenced this pull request Sep 4, 2024
Summary:
As titled, Save the checkpoint after the eager model preparation is done. The reason for this option is that the checkpoint can be used to do evaluations in other evaluation platforms, or with data that is not available in this eval_llama. We save the checkpoint here for consistency with eval_llama. The accuracy results we get from eval_llama can be used as a reference to other evaluations.


Reviewed By: mergennachin

Differential Revision: D62150021

Pulled By: iseeyuan
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62150021

@mergennachin mergennachin self-requested a review September 4, 2024 01:41
facebook-github-bot pushed a commit that referenced this pull request Sep 4, 2024
Summary:
As titled, Save the checkpoint after the eager model preparation is done. The reason for this option is that the checkpoint can be used to do evaluations in other evaluation platforms, or with data that is not available in this eval_llama. We save the checkpoint here for consistency with eval_llama. The accuracy results we get from eval_llama can be used as a reference to other evaluations.


Reviewed By: mergennachin, helunwencser

Differential Revision: D62150021

Pulled By: iseeyuan
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62150021

Summary:
As titled, Save the checkpoint after the eager model preparation is done. The reason for this option is that the checkpoint can be used to do evaluations in other evaluation platforms, or with data that is not available in this eval_llama. We save the checkpoint here for consistency with eval_llama. The accuracy results we get from eval_llama can be used as a reference to other evaluations.


Reviewed By: mergennachin, helunwencser

Differential Revision: D62150021

Pulled By: iseeyuan
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62150021

@facebook-github-bot facebook-github-bot merged commit 3268da2 into main Sep 7, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants