Qualcomm AI Engine Direct - support skip quantization #5070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5070
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 28ead61 with merge base 083b9e6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
haowhsu-quic
force-pushed
the
dev_skip_annotation
branch
from
4274084 to
22050a4
Compare
|
Hi @cccclai, this PR provides an approach of keeping designated nodes from quantizer annotation, it's also possible to delegate the unannotated nodes with QNN fp16. Please have a look, thank you. |
|
@haowhsu-quic hey sorry I miss the PR, could you rebase and I'll merge it? |
Summary: - Utility to skip operator annotation, unskipped nodes will be gathered into submodules and lowered with quantization annotation. Skipped nodes could either fallback to cpu or delegated with HTP fp16. - Fix uplevel breakage. - Refactor & retire some outdated implmentation.
haowhsu-quic
force-pushed
the
dev_skip_annotation
branch
from
22050a4 to
28ead61
Compare
cccclai
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: