[ExecuTorch] disable text animation in iOS Llama demo app #5134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We observed poor performance during generation, decreasing as the response got longer. Profiling revealed a lot of time spent in CoreAnimation on the main thread, which went away when I disabled this animation. Differential Revision: [D62308551](https://our.internmc.facebook.com/intern/diff/D62308551/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5134
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f00e26f with merge base 9739609 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Sep 6, 2024
We observed poor performance during generation, decreasing as the response got longer. Profiling revealed a lot of time spent in CoreAnimation on the main thread, which went away when I disabled this animation. Differential Revision: [D62308551](https://our.internmc.facebook.com/intern/diff/D62308551/) ghstack-source-id: 241388890 Pull Request resolved: #5134
|
This pull request was exported from Phabricator. Differential Revision: D62308551 |
larryliu0820
approved these changes
Sep 6, 2024
facebook-github-bot
merged commit ff47609
into
gh/swolchok/34/base
36 of 38 checks passed
kirklandsign
added a commit
that referenced
this pull request
Sep 8, 2024
Differential Revision: D62308551 Pull Request resolved: #5134 Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We observed poor performance during generation, decreasing as
the response got longer. Profiling revealed a lot of time spent in
CoreAnimation on the main thread, which went away when I disabled this
animation.
Differential Revision: D62308551