Remove overridden prefill API declaration in llava_runner.h

examples/models/llava/runner/llava_runner.h

@@ -29,62 +29,38 @@ class ET_EXPERIMENTAL LlavaRunner
       const std::string& tokenizer_path,
       const float temperature = 0.8f)
       : MultimodalRunner(model_path, tokenizer_path, temperature){};
-  bool is_loaded();
-  ::executorch::runtime::Error load();
+
+  bool is_loaded() override;
+
+  ::executorch::runtime::Error load() override;
+
   ::executorch::runtime::Error generate(
       std::vector<::executorch::extension::llm::Image> images,
       const std::string& prompt,
       int32_t seq_len = 1024,
       std::function<void(const std::string&)> token_callback = {},
       std::function<void(const ::executorch::extension::llm::Stats&)>
           stats_callback = {},
-      bool echo = true);
+      bool echo = true) override;
 
-  /**
-   * Prefill an LLaVA Module with the given images input.
-   * @param images The image input to LLaVA.
-   * @param start_pos The starting position in KV cache of the input in the LLM.
-   * It's passed as reference and will be updated inside this function.
-   * @return The error status of prefilling images.
-   */
   ::executorch::runtime::Error prefill_images(
       std::vector<::executorch::extension::llm::Image>& images,
-      int64_t& start_pos);
+      int64_t& start_pos) override;
 
-  /**
-   * Prefill an LLaVA Module with the given text input.
-   * @param prompt The text prompt to LLaVA.
-   * @param start_pos The starting position in KV cache of the input in the LLM.
-   * It's passed as reference and will be updated inside this function.
-   * @param bos The number of BOS (begin of sequence) token.
-   * @param eos The number of EOS (end of sequence) token.
-   * @return The generated token of the LLaVA Module after prefill prompt.
-   */
   ::executorch::runtime::Result<uint64_t> prefill_prompt(
       const std::string& prompt,
       int64_t& start_pos,
       int8_t bos = 0,
-      int8_t eos = 0);
+      int8_t eos = 0) override;
 
-  /**
-   * Generate tokens from the given prompt, starting from the given position.
-   * @param prompt The text prompt to LLaVA.
-   * @param seq_len The total sequence length, including the prompt tokens and
-   * new tokens.
-   * @param start_pos The starting position in KV cache of the input in the LLM.
-   * @param token_callback What to do after a token is generated.
-   * @param stats_callback What to do with Stats.
-   * @param echo Whether to echo the input prompt or not.
-   * @return The error code.
-   */
   ::executorch::runtime::Error generate_from_pos(
       const std::string& prompt,
       int32_t seq_len = 1024,
       int64_t start_pos = 0,
       std::function<void(const std::string&)> token_callback = {},
       std::function<void(const ::executorch::extension::llm::Stats&)>
           stats_callback = {},
-      bool echo = true);
+      bool echo = true) override;
 
  private:
   inline static const std::string kPresetPrompt =