[Android script] Add QNN related lib to AAR #5156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5156
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d1810fe with merge base 8afdc48 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
commented
Sep 6, 2024
| @@ -96,8 +109,8 @@ build_aar() { | |||
| # between Java and JNI | |||
| find jni -type f -name "libexecutorch_jni.so" -exec bash -c 'mv "$1" "${1/_jni/}"' bash {} \; | |||
| # Zip all necessary files into the AAR file | |||
| zip -r executorch.aar libs jni/*/libexecutorch.so AndroidManifest.xml | |||
| zip -r executorch-llama.aar libs jni/*/libexecutorch_llama_jni.so AndroidManifest.xml | |||
| zip -r executorch.aar libs jni/*/libexecutorch.so jni/*/libqnn*.so jni/*/libQnn*.so AndroidManifest.xml | |||
There was a problem hiding this comment.
this will generate warning in bash if no match found but return status is 0
in zsh i got error
guangy10
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.