Add Echo parameter to multimodal runner (llava) and jni layer #5181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5181
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 15025f7 with merge base eca9ed5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
cmodi-meta
force-pushed
the
llava-echo-parameter
branch
from
032a35d to
24081a7
Compare
kirklandsign
approved these changes
Sep 9, 2024
larryliu0820
reviewed
Sep 9, 2024
| * @param llamaCallback callback object to receive results. | ||
| * @return The error code. | ||
| */ | ||
| public native int generateFromPos( | ||
| String prompt, int seqLen, long startPos, LlamaCallback callback); | ||
| String prompt, int seqLen, long startPos, boolean echo, LlamaCallback callback); | ||
|
|
There was a problem hiding this comment.
Shouldn't echo be the last argument?
There was a problem hiding this comment.
On the Android side echo is not last argument, but from jni side echo is passed into the runner as the last argument.
There was a problem hiding this comment.
@larryliu0820 latest commits adds this as last parameter in all layers
larryliu0820
approved these changes
Sep 9, 2024
cmodi-meta
force-pushed
the
llava-echo-parameter
branch
from
317d749 to
15025f7
Compare
|
@cmodi-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.