Android refactor cmake build #5204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, in Java layer, add a note that if no args is given to forward, we will infer that the user wants to try with sample value
Instead, if we pass no args to forward(), we infer that the user wants to test against default inputs (ones) so we prepare the inputs for user
…into experiments-jni
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5204
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 957d1f1 with merge base 2863536 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
The failed job seems relevant to this refactoring |
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Fixed the issue |
guangy10
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libexecutorch.so. Note that by default (our CI server) we always build LLM as well. LLM is "a plugin" to the original JNI. It has minimal size impact. Users can disable it with-DEXECUTORCH_BUILD_LLAMA_JNI=OFFif they absolutely don't need it.