Skip to content

Add model execution scripts and runner #5217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

neuropilot-captain
Copy link
Collaborator

Add execution scripts and runner for 8 OSS models

Copy link

pytorch-bot bot commented Sep 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5217

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit de2503d with merge base 126abb5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2024
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave the original comments in neuropilot-captain@8f877a7

In short, we can use bundle program (the file will include expected inputs/outputs) instead of generating input files seperately.

@cccclai
Copy link
Contributor

cccclai commented Sep 10, 2024

Let's wait for the CI signal

@cccclai
Copy link
Contributor

cccclai commented Sep 10, 2024

oh btw looks like there are merge conflicts

This branch has conflicts that must be resolved
Use the [web editor](https://github.com/pytorch/executorch/pull/5217/conflicts) or the  to resolve conflicts.
Conflicting files
backends/mediatek/CMakeLists.txt
examples/mediatek/CMakeLists.txt

could you help resolving?

@cccclai
Copy link
Contributor

cccclai commented Sep 10, 2024

There are lint errors. Could you run lintrunner -a?

@cccclai
Copy link
Contributor

cccclai commented Sep 10, 2024

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cccclai merged this pull request in 7e374d7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants