Android: Leverage prefillPrompt and prefillImage on Llava #5224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Previously generate() calls prefillPrompt, prefilImage, and generateFromPos() sequentially. - To speed up processing time, we now call prefilPrompt() upon model loaded (saving 1.5s) - We call prefilImage() right after the user pick an image (before typing prompt) (saving 5-10s prompt typing wait) - generateFromPos() replaces generate() and no longer expects image as param as that has been done by prefilImage() - Fix minor \n bug on llava. Looks like llama3 needs \n\n but llava needs \n Reviewed By: larryliu0820 Differential Revision: D62411342
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5224
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit af6c3e0 with merge base 43e2f2d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62411342 |
larryliu0820
approved these changes
Sep 10, 2024
kirklandsign
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reviewed By: larryliu0820
Differential Revision: D62411342