Do not load constant_segment if only the placeholder exists #5229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5229
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit eef4064 with merge base 4cce620 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62455987 |
|
This pull request was exported from Phabricator. Differential Revision: D62455987 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 10, 2024
…5229) Summary: Pull Request resolved: pytorch#5229 If constant segment offsets only contains one value, it is the placeholder value for non-const tensors. This means the constant segment is empty, and does not need to be loaded. Differential Revision: D62455987
lucylq
force-pushed
the
export-D62455987
branch
from
e04b3b4 to
834e76a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62455987 |
lucylq
force-pushed
the
export-D62455987
branch
from
834e76a to
659b383
Compare
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 10, 2024
…5229) Summary: Pull Request resolved: pytorch#5229 1. If constant segment offsets only contains one value, it is the placeholder value for non-const tensors. This means the constant segment is empty, and does not need to be loaded. (T201034228) 2. Clean up before returning error in `prepare_input_tensors`. (T201165663) Differential Revision: D62455987
…5229) Summary: Pull Request resolved: pytorch#5229 1. If constant segment offsets only contains one value, it is the placeholder value for non-const tensors. This means the constant segment is empty, and does not need to be loaded. (T201034228) 2. Clean up before returning error in `prepare_input_tensors`. (T201165663) Differential Revision: D62455987
|
This pull request was exported from Phabricator. Differential Revision: D62455987 |
lucylq
force-pushed
the
export-D62455987
branch
from
659b383 to
eef4064
Compare
dbort
approved these changes
Sep 10, 2024
|
This pull request has been merged in 41b463e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: If constant segment offsets only contains one value, it is the placeholder value for non-const tensors. This means the constant segment is empty, and does not need to be loaded.
Differential Revision: D62455987