update set_tensor_data to use MethodMeta and set_input #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49747239 |
|
This pull request was exported from Phabricator. Differential Revision: D49747239 |
JacobSzwejbka
force-pushed
the
export-D49747239
branch
from
79a9b85 to
f7cd7c3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49747239 |
JacobSzwejbka
force-pushed
the
export-D49747239
branch
from
f7cd7c3 to
f26414d
Compare
Summary: Pull Request resolved: pytorch/executorch#523 None of these should exist in the public API, but we are out of time before MVP so just deprecating. Added a way to get a MethodMeta from method. Differential Revision: https://internalfb.com/D49747135 fbshipit-source-id: 0b2367641d1d2174b33a7d80246161f9f54f3a8f
Summary: Pull Request resolved: pytorch/executorch#524 Switch the util used in all of our examples to use "set_input" instead of get_input, set_data. Theres still more work to be done on this util like make it follow our style guide, put it in a more specific file, use RAII but thatll be after MVP. Reviewed By: dbort Differential Revision: D49747239 fbshipit-source-id: 8124b7941e4a6a9232f1ce173e4aeab9b4d2572b
|
This pull request was exported from Phabricator. Differential Revision: D49747239 |
JacobSzwejbka
force-pushed
the
export-D49747239
branch
from
f26414d to
ca45bbf
Compare
|
This pull request has been merged in 2a02032. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Switch the util used in all of our examples to use "set_input" instead of get_input, set_data.
Theres still more work to be done on this util like make it follow our style guide, put it in a more specific file, use RAII but thatll be after MVP.
Differential Revision: D49747239