Skip to content

Android app UI/flow improvements #5241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Android app UI/flow improvements #5241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...pps/android/LlamaDemo/app/src/main/java/com/example/executorchllamademo/PromptFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ public class PromptFormat {
public static final String SYSTEM_PLACEHOLDER = "{{ system_prompt }}";
public static final String USER_PLACEHOLDER = "{{ user_prompt }}";
public static final String ASSISTANT_PLACEHOLDER = "{{ assistant_response }}";
public static final String DEFAULT_SYSTEM_PROMPT = "Answer the questions in a few sentences";

public static String getSystemPromptTemplate(ModelType modelType) {
switch (modelType) {
Expand Down
6 changes: 3 additions & 3 deletions ...android/LlamaDemo/app/src/main/java/com/example/executorchllamademo/SettingsActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class SettingsActivity extends AppCompatActivity {
public SettingsFields mSettingsFields;

private DemoSharedPreferences mDemoSharedPreferences;
public static double TEMPERATURE_MIN_VALUE = 0.1;
public static double TEMPERATURE_MIN_VALUE = 0.0;

@Override
protected void onCreate(Bundle savedInstanceState) {
Expand Down Expand Up @@ -120,6 +120,7 @@ private void setupLoadModelButton() {
public void onClick(DialogInterface dialog, int whichButton) {
mSettingsFields.saveLoadModelAction(true);
mLoadModelButton.setEnabled(false);
onBackPressed();
}
})
.setNegativeButton(android.R.string.no, null)
Expand Down Expand Up @@ -208,8 +209,7 @@ public void afterTextChanged(Editable s) {
new DialogInterface.OnClickListener() {
public void onClick(DialogInterface dialog, int whichButton) {
// Clear the messageAdapter and sharedPreference
mSystemPromptEditText.setText(
PromptFormat.getSystemPromptTemplate(mModelType));
mSystemPromptEditText.setText(PromptFormat.DEFAULT_SYSTEM_PROMPT);
}
})
.setNegativeButton(android.R.string.no, null)
Expand Down
Loading