Rename exec_aten:: to executorch::aten:: #5296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Most code should use the exec_aten:: types: only aten-mode-aware code should refer directly to e.g. torch::executor::Tensor. ArrayRef is a little different because it's also a core type, but in that case it should be called executorch::runtime::ArrayRef. Differential Revision: D62476845
Summary: Modify any files that declare a `namespace exec_aten` to use the new `executorch::aten` namespace, and add an alias for the old namespace. Migration of users will happen in later diffs. Differential Revision: D62528437
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5296
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3ef1d33 with merge base a4be79f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62528437 |
mergennachin
approved these changes
Sep 12, 2024
|
This pull request has been merged in 905df29. |
swolchok
added a commit
that referenced
this pull request
Jan 28, 2025
fastmod 'exec_aten::' 'executorch::aten::' Manually fix op_sdpa.cpp to use ::executorch::aten, run lintrunner. (FWIW, I disagree with our use of nested namespaces for the reasons outlined in https://abseil.io/tips/130, but we can always find/replace back and leaving the migration unfinished seems worse.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Modify any files that declare a
namespace exec_atento use the newexecutorch::atennamespace, and add an alias for the old namespace. Migration of users will happen in later diffs.Differential Revision: D62528437