-
Notifications
You must be signed in to change notification settings - Fork 607
Set EXECUTORCH_BUILD_QNN=ON for benchmarking app build #5315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5315
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 709e5ac with merge base bcd156b ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a bit more context for this fix? Is the fix for AOT or runtime? Is it because the runtime will set EXECUTORCH_BUILD_QNN=OFF by default? I thought we will always to turn it on regardless it's for QNN or XNN
Runtime. Oh that's a good point. |
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Yeah, we don't want to add complexity to build the benchmark app. It should be just one flavor with all platform supported delegates for all models. |
@kirklandsign merged this pull request in 4b3f1c5. |
Runtime change. When we build the minibench app (the AAR component) we always integrate QNN backend support into it