Skip to content

Set EXECUTORCH_BUILD_QNN=ON for benchmarking app build #5315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Sep 12, 2024

Runtime change. When we build the minibench app (the AAR component) we always integrate QNN backend support into it

Copy link

pytorch-bot bot commented Sep 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5315

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 709e5ac with merge base bcd156b (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2024
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@guangy10 guangy10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a bit more context for this fix? Is the fix for AOT or runtime? Is it because the runtime will set EXECUTORCH_BUILD_QNN=OFF by default? I thought we will always to turn it on regardless it's for QNN or XNN

@kirklandsign
Copy link
Contributor Author

Can you add a bit more context for this fix? Is the fix for AOT or runtime? Is it because the runtime will set EXECUTORCH_BUILD_QNN=OFF by default? I thought we will always to turn it on regardless it's for QNN or XNN

Runtime. Oh that's a good point.

@kirklandsign kirklandsign changed the title export EXECUTORCH_BUILD_QNN when we benchmark QNN Set EXECUTORCH_BUILD_QNN=ON for benchmarking app build Sep 12, 2024
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10
Copy link
Contributor

Can you add a bit more context for this fix? Is the fix for AOT or runtime? Is it because the runtime will set EXECUTORCH_BUILD_QNN=OFF by default? I thought we will always to turn it on regardless it's for QNN or XNN

Runtime. Oh that's a good point.

Yeah, we don't want to add complexity to build the benchmark app. It should be just one flavor with all platform supported delegates for all models.

@facebook-github-bot
Copy link
Contributor

@kirklandsign merged this pull request in 4b3f1c5.

@kirklandsign kirklandsign deleted the qnn-benchmark branch September 12, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants